Repository navigation
Admit hosted work only on a configured deployment - #546
Merged
Merged
Conversation
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two run states that production can no longer reach are removed, together with the test convenience that kept them alive.
/v1behaviour is unchanged.Admission.
placement.CheckAdmissionrefuses an unclaimed deployment, or one without a provider, withErrNodeUnavailable.DecidePlacementwithout a provider does the same. In production/v1still answers 503execution_unavailablefirst, so only a request that races past that check sees the new error. The wrong comments, which said an unclaimed deployment admits everything and that Web setup claims it, are fixed.Node-less, non-direct allocations.
kept_atcolumn and every query branch and guard that used it,KeepRuntimeAllocation,AllocationTx.Keep,Allocation.KeptAtandKeepAllocation.ExecutionOperations.CheckRunning(ctx, Allocation) (Allocation, error). It checks that the Session is undeleted, the device is bound and the allocation isrunning, and changes nothing. Only the call expressions changed.000096_configured_admission.sqladds a one-time upgrade guard and dropskept_at. The upgrade refuses while there are node-less, non-direct allocations or pending hosted Environments on an unclaimed deployment. There is no runtime constraint.Claimno longer refuses on leftover unclaimed work.Worker.
StartWorkerrequiresManagedRuntimes. Deleted: every nil arm,RequireUnclaimed, and the test that started a Worker without runtimes.Dead modes.
runtimehistory.CollectionOnReadand the history route's "not configured" 503.source_not_configured, removed from the/core/v1enum, the client and the locales.coremetricsslot and daemon fields.NewRulesreturns the typedErrPublicURLRequiredfor an empty URL.Tests.
One shared test installation ID,
services/core/tests/testdata/installation.id, read by bothofficial_client.pyand the Go Workers. The official-client CI step is back to its natural order.Hosted tests use
configuredStore: an isolated database set up the way Web setup does.pgtest.OpenIsolatedcopies a migrated template database instead of migrating each copy. Migration and copying share one advisory lock, because Postgres refuses to copy a template while another session is connected to it.Per-test cipher literals are replaced by
pgtest.CredentialKey.Timing:
tests/integrationexecutionDocs (en and zh):
sandbox-provider.md,sandbox-deployment.md,core-errors.md,core-metrics.md,runtime-observability.mdandruntime-observability-api.md.CONTRIBUTING.mdmentions the template database.Net: non-test −127 (of which −53 generated), test −241, docs −2.
Checks.
go buildandgo vet;sqlc-generateandmake openapiwith no drift.pgtestpackage, including all thirteenOpenIsolatedpackages in parallel on a fresh template.check-names, links and translations;pnpm typecheckandtest:web.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.