Repository navigation
Sync main bb1485ec into the cutover - #551
Merged
Merged
Conversation
- The local-environment test no longer races managed-runtime maintenance: it asserts the read never binds the general device, while maintenance may bind its own. - Drop Docker's extra_hosts, a node setting nothing produces. - Web's runtime_history_unavailable text matches the contract: the history is temporarily unavailable.
Migrations: main owns 000096_configured_admission; the cutover's 000096_session_runtime_assignments becomes 000097 and 000097_sandbox_link_authority becomes 000098. The agent-host migration test now rolls back to 97. Ported tests: - TestAgentExecutionDefaultsRejectInvalidSavedProvider uses configuredStore and its credential cipher. - The node isolation fixture starts its worker with startWebWorker and the Link relay. - The Docker Serve test reaches the host through the bridge gateway with its own certificate, since main dropped extra_hosts. Dropped assertions: - CheckRunning's "bound to another device" unit case: the cutover removed the device clause from the running-allocation check. - local_environment_devices' durable exact binding: Sessions bind only agent hosts after the cutover. local_environment_worker keeps the cutover's strict check that the read binds no device. TestRuntimeDeploymentClaimAdoptsNoUnclaimedWork stays deleted with RequireUnclaimed, as on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges
mainbb1485e (#546 configured admission, #547 review findings) into the cutover.mainowns 000096 (configured_admission), so the cutover'ssession_runtime_assignmentsbecomes 000097 andsandbox_link_authority000098.KeepAllocationisCheckRunning;kept_at,RequireUnclaimed,CollectionOnReadandsource_not_configuredare gone; placement checks the provider before the public origin.main'sconfiguredStore, shared installation ID andOpenIsolatedwith the agent-host binding and Link relay.extra_hostsis gone.main'sCheckRunningcase for a Session bound to another device and its durable-binding check for local Environment devices (Sessions bind only agent hosts after the cutover).Checks: whole-module build and vet; unit tests of the 22 touched packages; integration tests of every conflicted or fixture-changed file and the migration tests (138 pass, 4 skip for the official SDK);
make check-sqlc openapi check-names check-docs check-ci; Webtscand the affected vitest files.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.