Repository navigation
Settle the node configuration and admission review findings - #547
Merged
Merged
Conversation
- The local-environment test no longer races managed-runtime maintenance: it asserts the read never binds the general device, while maintenance may bind its own. - Drop Docker's extra_hosts, a node setting nothing produces. - Web's runtime_history_unavailable text matches the contract: the history is temporarily unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the batched blind review of #543 (vendor node settings in the adapter) and #546 (configured admission).
TestLocalEnvironmentWorkerRejectsGeneralDeviceDespiteCapabilityasserted that a second hosted Session has no device. Since Admit hosted work only on a configured deployment #546 the Worker always runs managed-runtime maintenance, which may legitimately bind amanaged-runtimedevice to that Session within its 5s cycle. The test now asserts what it means: the read never binds the general device. Verified by forcing a 6s wait before the assertion: maintenance boundmanaged-runtimeand the test passed.extra_hosts. The Docker node setting has no producer: the installer never writes it and nothing else does. Removed fromdocker.Native,docker.Config, the container options and the configuration reference (en and zh, with a newsource_hash).runtime_history_unavailablesaid history is unavailable "on this Core", which described the not-configured mode Admit hosted work only on a configured deployment #546 deleted. It now matchescore-errors.md: temporarily unavailable.Checks:
go build ./...,go veton the touched packages, the Docker adapter andcmd/sandbox-nodetests, the local-environment Worker integration tests (4 runs, plus the forced-wait probe), the translation test andcheck-names.py.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.