Repository navigation
Replace broken link with link to Moffat's paper - #1369
Merged
Merged
Conversation
rmjarvis
commented
Oct 16, 2026
| # even though we eventually convert to images which are strided in this format. | ||
| coef = np.zeros((nk, nk, NSED), dtype=np.complex128) | ||
| Sigma = np.empty((nk, nk, NSED, NSED), dtype=np.complex128) | ||
| Sigma = np.zeros((nk, nk, NSED, NSED), dtype=np.complex128) |
Member
Author
There was a problem hiding this comment.
With this as empty, the tests occasionally randomly fail because some uninitialized values get through to the repr and the pickle test fails when expecting an exact match on the numpy arrays. Switching to zeros makes this more robust and has negligible speed impact.
rmandelb
approved these changes
Oct 18, 2026
rmandelb
left a comment
rmandelb
left a comment
Member
There was a problem hiding this comment.
Both changes seem fine - though unrelated. Is it possible some changes from two different issues ended up on the same branch?
Member
Author
|
The main one was just the url, but then the CI failed for this unrelated reason, so I fixed that too. |
Member
|
Just FYI, for doc-only changes like this, adding a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Moffat documentation has a broken link to some notes by @ehneilsen, which don't exist online anymore, and probably weren't the best reference in any case. This PR replaces that link with a link to Moffat's original paper.