Skip to content

Replace broken link with link to Moffat's paper #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmjarvis merged 2 commits into from
Oct 19, 2026
+2 −2
Merged

Replace broken link with link to Moffat's paper #1369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65a136a
Replace broken link with link to Moffat's paper
rmjarvis Oct 16, 2026
c7b5b35
Use zeros rather than empty for Sigma, since not all array values are…
rmjarvis Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion galsim/moffat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class Moffat(GSObject):

For more information, refer to

http://home.fnal.gov/~neilsen/notebook/astroPSF/astroPSF.html
https://ui.adsabs.harvard.edu/abs/1969A%26A.....3..455M/abstract

A Moffat can be initialized using one (and only one) of three possible size parameters:
``scale_radius``, ``fwhm``, or ``half_light_radius``. Exactly one of these three is required.
Expand Down
2 changes: 1 addition & 1 deletion galsim/real.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1265,7 +1265,7 @@ def _initialize(self, imgs, bands, xis, PSFs,
# Note: put NSED axis last, since significantly faster to compute them this way,
# even though we eventually convert to images which are strided in this format.
coef = np.zeros((nk, nk, NSED), dtype=np.complex128)
Sigma = np.empty((nk, nk, NSED, NSED), dtype=np.complex128)
Sigma = np.zeros((nk, nk, NSED, NSED), dtype=np.complex128)

@rmjarvis rmjarvis Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this as empty, the tests occasionally randomly fail because some uninitialized values get through to the repr and the pickle test fails when expecting an exact match on the numpy arrays. Switching to zeros makes this more robust and has negligible speed impact.


# Solve the weighted linear least squares problem for each Fourier mode. This is
# effectively a constrained chromatic deconvolution. Take advantage of symmetries.
Expand Down
Loading