Repository navigation
Kill watcher fixtures directly instead of via denied group signals - #154
Merged
Merged
Conversation
The headlesscode-job tests cleaned up exec'd sleep fixtures with process.kill(-pid), which is EPERM in the eval sandbox. The kill was swallowed, the fixture survived, and the watcher (correctly, via procfs) still saw a live group, failing the baseline gate. The fixtures are single-process groups, so direct child kill is exactly equivalent and policy-immune.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the RSI baseline gate: headlesscode-job fixture cleanup used bare group kill, denied (EPERM) in the eval sandbox, leaving sleep fixtures alive so the watcher correctly kept the job spawned. Direct child kill is equivalent for these single-process exec fixtures. Verified: host green; seccomp container denying negative-pid kill passes all 11 file tests. Fails in the fleet without this change (rsi-20261013123114 baseline).