Skip to content

Kill watcher fixtures directly instead of via denied group signals #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
w4ffl35 merged 1 commit into from
Oct 13, 2026
Merged

Kill watcher fixtures directly instead of via denied group signals #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/watcher/__tests__/headlesscode-job.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,9 @@ async function testForgedWorktreeMarkersCannotFinishLiveWorker(): Promise<void>
assert.equal(h.closed, false, "worker-controlled markers cannot close an issue while its process group is live")
} finally {
if (child.pid) {
try { process.kill(-child.pid, "SIGKILL") } catch { /* fixture already exited */ }
// Direct kill: the exec'd fixture is a single-process group,
// and group signals are denied in the eval sandbox.
try { child.kill("SIGKILL") } catch { /* fixture already exited */ }
}
}
await run(h)
Expand Down Expand Up @@ -198,7 +200,9 @@ async function testStaleAttemptAndUnknownIdentityStayRunning(): Promise<void> {
assert.equal((await loadWatcherState(h.stateFile)).processed[String(h.issue.number)]?.status, "spawned", "a reused PID does not prove the captured process group is gone")
} finally {
if (reused.pid) {
try { process.kill(-reused.pid, "SIGKILL") } catch { /* fixture already exited */ }
// Direct kill: the exec'd fixture is a single-process group,
// and group signals are denied in the eval sandbox.
try { reused.kill("SIGKILL") } catch { /* fixture already exited */ }
}
}
}
Expand Down
Loading