Repository navigation
Quality: RSI controller decomposition (tests-first) #126
Description
Target: src/rsi/controller.ts (694 standards violations, 19 complexity/nesting findings) plus src/rsi/inference-broker.ts (278 / 13) if time permits. Inventory: npm run check-standards, npm run check-architecture.
Brief:
- Measure: run npm run coverage -- --filter rsi and record the module percentage.
- Tests FIRST: add missing unit tests for every function you will touch (repo style: src//tests/.test.ts via tsx, auto-discovered). Do not reshape anything until its tests exist and pass.
- Refactor toward docs/typescript-standards.md (file 250 lines, function 20, complexity 10): extract cohesive modules (planning, selection, broker grants, reporting). No behavior change; keep all call sites compiling.
- Gates, all green: npx tsc --noEmit; npm test (full); npm run check-standards; npm run check-architecture; regenerate both baselines in the same change; coverage must not regress (npm run coverage -- --min 24).
Activity
Merge pull request #151 from Capsize-Games/issues/w8-2026-10-13
w4ffl35 commentedon Oct 13, 2026
Partial progress landed via #151 (merged): candidates/fleet/integrity/proof slices extracted from controller.ts with tests-first coverage, both baselines regenerated. controller.ts is now 1410 lines — still far from the 250-line target — and inference-broker.ts (866 lines) is untouched. Keeping this open for the remaining extraction (planning, selection, broker grants, reporting). #127 closed via #148/#149.
w4ffl35 commentedon Oct 13, 2026
RSI self-repair loop status: the eval baseline is green two runs in a row after the sandbox fixes (#152 PTY skip, #153 abort fallback, #154 watcher fixture kill, #155 pause flake widening) plus operator fixes (30-min trial timeout, clean-checkout requirement now tracked in #156, broker env for the development benchmark). Genuine selection pressure confirmed: c02 of run 4130236a was correctly rejected on a broken regression gate, and c01 passed regression before hitting the (now fixed) broker env gap. A fresh run with all fixes is in flight to attempt the first real selection.