[AutoPR azure-resourcemanager-containerservicenodecustomization]-generated-from-SDK Generation - Java-6846851 - #50458
Conversation
…osoft.ContainerService/nodecustomization/tspconfig.yaml', and CommitSHA: '431bfdd102a3a4f63b74380462b055f0c1fc5f2f' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6837268 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟡 Changes recommended
The module path and CI service-directory registration do not match the artifact identity and must be aligned before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a generated beta Azure Resource Manager Java client for Container Service Node Customization API version 2025-09-02-preview.
Changes:
- Adds generated clients, models, implementations, samples, and tests.
- Adds Maven, CI, versioning, TypeSpec provenance, documentation, and native-image metadata.
- Adds serialization and mock-service coverage.
The module path and CI service-directory registration require alignment with the artifact identity.
File summaries
| File | Summary |
|---|---|
sdk/containerservicenodecustomization/pom.xml |
Defines the service aggregator module. |
sdk/containerservicenodecustomization/ci.yml |
Configures CI and release metadata. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/tsp-location.yaml |
Records the TypeSpec source commit. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/UserAssignedIdentityTests.java |
Adds identity model tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/OperationsListMockTests.java |
Adds operations mock tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/OperationListResultTests.java |
Adds operation list-result tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/OperationInnerTests.java |
Adds operation model tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/OperationDisplayTests.java |
Adds operation display tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationVersionListResultTests.java |
Adds version list-result tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationVersionInnerTests.java |
Adds version model tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationUpdateTests.java |
Adds update model tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsListVersionsMockTests.java |
Adds version-list mock tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsListMockTests.java |
Adds list mock tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsListByResourceGroupMockTests.java |
Adds resource-group list mock tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsGetVersionWithResponseMockTests.java |
Adds version retrieval mock tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsGetByResourceGroupWithResponseMockTests.java |
Adds resource retrieval mock tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationScriptTests.java |
Adds script model tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsCreateOrUpdateMockTests.java |
Adds create/update mock tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationPropertiesTests.java |
Adds properties tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationListResultTests.java |
Adds list-result tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/test/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationInnerTests.java |
Adds customization model tests. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/samples/java/com/azure/resourcemanager/containerservicenodecustom/generated/OperationsListSamples.java |
Adds operations listing sample. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/samples/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsUpdateSamples.java |
Adds update sample. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/samples/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsListVersionsSamples.java |
Adds version listing sample. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/samples/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsListSamples.java |
Adds subscription listing sample. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/samples/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsListByResourceGroupSamples.java |
Adds resource-group listing sample. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/samples/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsGetVersionSamples.java |
Adds version retrieval sample. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/samples/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsGetByResourceGroupSamples.java |
Adds resource retrieval sample. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/samples/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsDeleteVersionSamples.java |
Adds version deletion sample. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/samples/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsDeleteSamples.java |
Adds deletion sample. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/samples/java/com/azure/resourcemanager/containerservicenodecustom/generated/NodeCustomizationsCreateOrUpdateSamples.java |
Adds create/update sample. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/resources/META-INF/native-image/com.azure.resourcemanager/azure-resourcemanager-containerservicenodecustom/reflect-config.json |
Adds native-image reflection metadata. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/resources/META-INF/native-image/com.azure.resourcemanager/azure-resourcemanager-containerservicenodecustom/proxy-config.json |
Adds native-image proxy metadata. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/resources/META-INF/azure-resourcemanager-containerservicenodecustom_metadata.json |
Adds generation metadata. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/resources/azure-resourcemanager-containerservicenodecustom.properties |
Adds package version metadata. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/module-info.java |
Defines module exports. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/package-info.java |
Documents the root package. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/UserAssignedIdentity.java |
Adds the identity model. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/ScriptType.java |
Adds the script type enum. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/ProvisioningState.java |
Adds the provisioning state enum. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/package-info.java |
Documents the models package. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/Origin.java |
Adds the origin enum. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/Operations.java |
Adds the operations collection interface. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/OperationDisplay.java |
Adds the operation display model. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/Operation.java |
Adds the operation interface. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/NodeCustomizationVersion.java |
Adds the version interface. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/NodeCustomizationUpdate.java |
Adds update properties. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/NodeCustomizationScript.java |
Adds customization scripts. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/NodeCustomizationProperties.java |
Adds resource properties. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/NodeCustomization.java |
Adds the public resource interface. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/ExecutionPoint.java |
Adds the execution point enum. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/models/ActionType.java |
Adds the action type enum. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/implementation/ResourceManagerUtils.java |
Adds management utility helpers. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/implementation/package-info.java |
Documents the implementation package. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/implementation/OperationsImpl.java |
Implements the operations collection. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/implementation/OperationsClientImpl.java |
Implements operations REST calls. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/implementation/OperationImpl.java |
Implements operation resources. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/implementation/NodeCustomizationVersionImpl.java |
Implements version resources. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/implementation/NodeCustomizationsImpl.java |
Implements the resource collection. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/implementation/NodeCustomizationImpl.java |
Implements resource management flows. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/implementation/models/OperationListResult.java |
Adds the operation list-result model. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/implementation/models/NodeCustomizationVersionListResult.java |
Adds the version list-result model. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/implementation/models/NodeCustomizationListResult.java |
Adds the customization list-result model. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/implementation/ContainerServiceNodeCustomizationManagementClientImpl.java |
Implements the management client. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/implementation/ContainerServiceNodeCustomizationManagementClientBuilder.java |
Adds the client builder. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/fluent/package-info.java |
Documents the fluent package. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/fluent/OperationsClient.java |
Defines the operations client. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/fluent/models/package-info.java |
Documents fluent models. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/fluent/models/OperationInner.java |
Adds the fluent operation model. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/fluent/models/NodeCustomizationVersionInner.java |
Adds the fluent version model. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/fluent/models/NodeCustomizationInner.java |
Adds the fluent customization model. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/fluent/ContainerServiceNodeCustomizationManagementClient.java |
Defines the fluent management client. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/src/main/java/com/azure/resourcemanager/containerservicenodecustom/ContainerServiceNodeCustomizationManager.java |
Adds the management entry point. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/SAMPLE.md |
Adds the sample index. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/README.md |
Adds package documentation. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/pom.xml |
Defines the management artifact. |
sdk/containerservicenodecustomization/azure-resourcemanager-containerservicenodecustom/CHANGELOG.md |
Documents the beta release. |
pom.xml |
Registers the service module. |
eng/versioning/version_client.txt |
Adds artifact versioning metadata. |
Review details
Suppressed comments (1)
sdk/containerservicenodecustomization/ci.yml:43
- [MGMT-FOLDER] The generated artifact is
azure-resourcemanager-containerservicenodecustom, whose third module segment iscontainerservicenodecustom, but this CI registration usescontainerservicenodecustomizationas the service directory. This mismatch can route service-directory discovery, versioning, and CI to the wrong service; please move the module/registration tosdk/containerservicenodecustomor correct the upstreamservice-dirconfiguration before regenerating.
- Files reviewed: 53/82 changed files
- Comments generated: 1
- Review effort level: Lite
| <version>1.0.0</version><!-- Need not change for every release--> | ||
|
|
||
| <modules> | ||
| <module>azure-resourcemanager-containerservicenodecustom</module> |
This comment has been minimized.
This comment has been minimized.
Weidong Xu (weidongxu-microsoft)
left a comment
There was a problem hiding this comment.
The new Java library package name has not received an exact Java package-name approval. Please complete approval for com.azure.resourcemanager:azure-resourcemanager-containerservicenodecustom (com.azure.resourcemanager.containerservicenodecustom) and regenerate the SDK if the approved name changes.
|
Opened Azure/azure-rest-api-specs#46378 to use |
Remove the incorrectly named initial generation before regenerating from the corrected TypeSpec configuration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 69da8151-cc69-4b91-9c23-92722f5777c0
…osoft.ContainerService/nodecustomization/tspconfig.yaml', and CommitSHA: '0ffaaff2b961a1f1792b811f8fe7a17e4004f097' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6837539 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
This comment has been minimized.
This comment has been minimized.
Remove the incorrectly shortened package generation before regenerating with the corrected cross-language name. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 69da8151-cc69-4b91-9c23-92722f5777c0
…osoft.ContainerService/nodecustomization/tspconfig.yaml', and CommitSHA: '150220a3520f0d8fa42c202f9adb6d5cf53fd278' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6837885 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 69da8151-cc69-4b91-9c23-92722f5777c0
Automated management AutoPR review
Informational
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 69da8151-cc69-4b91-9c23-92722f5777c0
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 69da8151-cc69-4b91-9c23-92722f5777c0
This reverts commit 4a79d65.
|
The path-length pipeline change has been moved to #50462 and removed from this AutoPR. That prerequisite needs to merge before this PR's Build Analyze path-length check can pass. The module-local Checkstyle suppression file now includes the Resource Manager |
…tion-package-suppression
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 69da8151-cc69-4b91-9c23-92722f5777c0
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 69da8151-cc69-4b91-9c23-92722f5777c0
|
wait for specs PR Azure/azure-rest-api-specs#46378 |
…osoft.ContainerService/nodecustomization/tspconfig.yaml', and CommitSHA: '2547c2f9618e4622de1f10e40e971563f22ca9af' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6846851 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
/azp run prepare-pipelines |
|
namespace review completed Azure/azure-rest-api-specs#46378 |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Configurations: 'specification/containerservice/resource-manager/Microsoft.ContainerService/nodecustomization/tspconfig.yaml', and CommitSHA: '2547c2f9618e4622de1f10e40e971563f22ca9af' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6846851 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36534 Submitted by: v-ruih@microsoft.com