Suppress NodeCustomization package name check - #50465
Merged
Weidong Xu (weidongxu-microsoft) merged 1 commit intoSep 16, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 69da8151-cc69-4b91-9c23-92722f5777c0
Weidong Xu (weidongxu-microsoft)
requested review from
a team,
Jonathan Giles (JonathanGiles),
Alan Zimmer (alzimmermsft),
Moary Chen (moarychan) and
Xiaolu Dai (saragluna)
as code owners
September 15, 2026 14:06
|
Azure Pipelines: Successfully started running 2 pipeline(s). 33 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Weidong Xu (weidongxu-microsoft)
September 15, 2026 14:07
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped suppression has no unresolved review comments.
Pull request overview
Adds a Checkstyle package-name suppression for the generated Node Customization management SDK.
Changes:
- Suppresses
PackageNamechecks forcom.azure.resourcemanager.containerservicenodecustomization.*. - Follows existing resource-manager suppression patterns.
File summaries
| File | Description |
|---|---|
eng/lintingconfigs/checkstyle/track2/checkstyle-suppressions.xml |
Adds the package-specific suppression. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Weidong Xu (weidongxu-microsoft)
requested a review
from Xiaofei Cao (XiaofeiCao)
September 16, 2026 01:40
Xiaofei Cao (XiaofeiCao)
approved these changes
Sep 16, 2026
Weidong Xu (weidongxu-microsoft)
merged commit Sep 16, 2026
858a247
into
Azure:main
27 checks passed
Weidong Xu (weidongxu-microsoft)
deleted the
copilot/nodecustomization-global-package-suppression
branch
September 16, 2026 01:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the global package-name exception required by the generated Node Customization management SDK.
Prerequisite for #50458.
This is need for spec PR to pass Java CI https://github.com/Azure/azure-rest-api-specs/pull/46378/checks?check_run_id=104336403787
The SDK PR #50458 may not be merged till service is ready.