Skip to content

Relax Java pipeline path base length to 30 - #50462

Merged
Weidong Xu (weidongxu-microsoft) merged 1 commit into
Azure:mainfrom
weidongxu-microsoft:weidongxu/relax-java-path-length-30
Sep 15, 2026
Merged

Weidong Xu (weidongxu-microsoft) merged 1 commit into
Azure:mainfrom
weidongxu-microsoft:weidongxu/relax-java-path-length-30

Conversation

@weidongxu-microsoft

Copy link
Copy Markdown
Member

Summary

  • Reduce the assumed Windows checkout-root reservation from 38 to 30 characters.
  • Apply the same limit to standard CI and patch-release pipelines.

This is the smallest practical relaxation needed by the Node Customization management SDK: its longest generated path is 229 repository-relative characters, totaling 259 with the new reservation.

Follow-up for #50458.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 69da8151-cc69-4b91-9c23-92722f5777c0
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
34 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The scoped path-length updates address the stated requirement with no unresolved review issues.

Pull request overview

Relaxes the Windows checkout path reservation from 38 to 30 characters for Java CI and patch-release pipelines.

Changes:

  • Updates standard CI path validation.
  • Applies the same limit to patch-release validation.
File summaries
File Description
eng/pipelines/templates/stages/archetype-sdk-client-patch.yml Lowers the patch-release path reservation.
eng/pipelines/templates/jobs/ci.yml Lowers the standard CI path reservation.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@weidongxu-microsoft
Weidong Xu (weidongxu-microsoft) merged commit 9dd9bd0 into Azure:main Sep 15, 2026
22 checks passed
@weidongxu-microsoft
Weidong Xu (weidongxu-microsoft) deleted the weidongxu/relax-java-path-length-30 branch September 15, 2026 12:38
pull Bot pushed a commit to jrcribb/cadl that referenced this pull request Sep 16, 2026
## Summary

- Align generated Java path calculations with the 30-character
checkout-root reservation from Azure/azure-sdk-for-java#50462.
- Preserve test and sample class names that now fit under the relaxed
limit.
- Apply the same reservation to GraalVM resource paths and update
boundary tests.

## Validation

- `npm run build`
- `npm run format`
- `npm run lint`
- `pnpm format`
- `mvn test --projects http-client-generator-core --define
"test=ClassNameUtilTests" -f .\generator\pom.xml`

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 277f389f-e041-4191-8637-c3843c839b05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants