Skip to content

Fix Stats crash when the blog is released before the view loads #25971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crazytonyli wants to merge 1 commit into
base: trunk
Choose a base branch
from
+10 −1
Open

Fix Stats crash when the blog is released before the view loads #25971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions WordPress/Classes/Services/BlogService.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@ - (void)syncBlog:(Blog *)blog
success:(void (^)(void))success
failure:(void (^)(NSError *error))failure
{
if (!blog) {
// Reuse an existing error type. This branch is an edge case and no caller inspects the error.
NSError *error = [NSError errorWithDomain:WordPressComRestApiErrorDomain
code:WordPressComRestApiErrorCodeInvalidInput
userInfo:@{NSDebugDescriptionErrorKey: @"Cannot sync a nil blog"}];
failure(error);
return;
}

if ([blog supports:BlogFeatureWpComRESTAPI]) {
id<BlogServiceRemote> remote = [self remoteForBlog:blog];
if ([remote isKindOfClass:[BlogServiceRemoteREST class]]) {
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/ViewRelated/Stats/StatsViewController.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

@interface StatsViewController : UIViewController

@property (nonatomic, weak, nullable) Blog *blog;
@property (nonatomic, strong, nullable) Blog *blog;
@property (nonatomic, copy, nullable) void (^dismissBlock)(void);

@end