Fix Stats crash when the blog is released before the view loads - #25971
Open
crazytonyli wants to merge 1 commit into
Open
Fix Stats crash when the blog is released before the view loads#25971crazytonyli wants to merge 1 commit into
crazytonyli wants to merge 1 commit into
Conversation
`StatsViewController.blog` was a weak reference. Every entry point set it and returned before `viewDidLoad` ran, so when nothing else retained the Core Data object (for example a push cold launch opening a notification's stats), the reference was nil by the time `initStats` called `syncBlog:`. Since 27.2 that nil reached `existingObject(with:)` and threw `NSInvalidArgumentException`. Make the property strong so the controller owns the blog for its lifetime, and have `syncBlog:` report a nil blog through its failure block instead of crashing. Fixes JETPACK-IOS-1KHV.
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 34131 | |
| Version | PR #25971 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 61e0266 | |
| Installation URL | 4bcufnvuol9kg |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 34131 | |
| Version | PR #25971 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 61e0266 | |
| Installation URL | 5bu2r3gh6tr6o |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://a8c.sentry.io/issues/7701581438