kubectl: forward --context and --cluster into completion generators

[warp-agent-staging]

Description

The kubectl generators build their query command from the tokens already on the line, so completions are scoped to what the user has typed. Only --kubeconfig and --namespace/-n were forwarded, so a --context (or --cluster) written on the command line was silently dropped. With

kubectl --context staging-cluster --namespace <TAB>

the generated command was kubectl … get namespace -o custom-columns=:.metadata.name — no --context — so the suggestions came from the shell's active context rather than from staging-cluster. The same omission affected the resource and api-resources generators.

This is the one remaining symptom of warpdotdev/warp#5186 (the --context/--cluster value completions themselves were fixed by #247), and it is what warpdotdev/warp#3929 asks for directly (kubectl --context staging-cluster -n project1 get pods).

Changes

Three independent commits, in order:

1. kubectl: forward --context and --cluster — mirrors the existing --kubeconfig / --namespace handling via space_or_equals_delimited_option_value, so both --flag value and --flag=value work. Forwarded values are now shell-quoted: tokens reach generators with their shell quoting already stripped, so a value containing whitespace previously split into multiple arguments and produced a broken command. Quoting uses single quotes with ' escaped as '\'', the technique git.rs and scp.rs already use for interpolated token values, which also neutralizes $, backticks and backslashes.
2. kubectl: complete --user values — kubectl --user <TAB> had no generator and fell back to file paths; kubectl config get-users supplies them.
3. kubecolor, oc: complete --context, --cluster and --user values — both specs declare these as persistent options with no generatorName despite already registering kubectl's generators, so kubecolor get --context <TAB> still showed file paths. This is the un-migrated version of what Fix kubectl --context and --cluster persistent flag completions #247 fixed for kubectl. Commit 3 depends on commit 2 for the user generator; dropping commit 2 means dropping the --user lines in commit 3 as well.

Commits 2 and 3 are drive-by wiring — drop either without affecting the fix in commit 1.

Overlap with #331

#331 was opened ~15 minutes before this PR and independently fixes the same --context/--cluster forwarding gap, plus --user. Only one of these should land. The differences, so a reviewer can pick quickly:

• Forward --context/--cluster/--user in kubectl generators #331 additionally makes space_or_equals_delimited_option_value take the last occurrence of a repeated flag and stop at a bare --, matching pflag semantics. That is a genuine improvement this PR does not have.
• Forward --context/--cluster/--user in kubectl generators #331 also forwards --user; this PR deliberately only adds --user value completion.
• This PR additionally wires --context/--cluster/--user for kubecolor and oc, which Forward --context/--cluster/--user in kubectl generators #331 does not touch, and asserts the full generated command string for the reported case.
• The shell-quoting here was changed to match Forward --context/--cluster/--user in kubectl generators #331's approach after reading it; credit for that belongs to Forward --context/--cluster/--user in kubectl generators #331.

If #331 lands, the useful remainder of this PR is its third commit (kubecolor/oc wiring) plus the full-command test, which can be rebased on top. The companion rev bump in warpdotdev/warp needs to be re-pointed at whichever commit lands.

Notes

• No regression risk to the already-working --context/--cluster value completion. While completing those values the partial value gets forwarded into config get-contexts / get-clusters, which kubectl accepts and still answers with the full list (exit 0).
• Worst case is empty completions, not wrong ones. An invalid context on a cluster query exits non-zero, which the completer turns into zero suggestions rather than surfacing error text.
• --user is deliberately not forwarded into the generated commands; only its own value completion is added. Forwarding it was outside the scope of this fix.
• For oc, the context/cluster/user generators run kubectl (they are kubectl's generators, shared). That matches how oc's existing --namespace generator already behaves.

Testing

./script/presubmit passes: prettier JSON check, cargo fmt, cargo clippy --all-targets --all-features -D warnings, and cargo test (161 tests).

New and tightened tests assert the generated command, not merely that completion happens:

• test_full_generated_command_forwards_context_to_namespace_query asserts the complete command string for the reported case.
• test_context_long_flag_before_subcommand, test_context_flag_after_subcommand, test_context_equals_syntax, test_cluster_flag_forwarded, test_cluster_equals_syntax.
• test_no_flags_forwarded_when_absent, test_forwarded_values_with_whitespace_are_quoted, test_forwarded_value_with_single_quote_is_escaped and test_forwarded_value_does_not_expand_shell_metacharacters.
• test_context_and_namespace_flags_before_subcommand already passed a --context but only asserted namespace forwarding, leaving the gap unasserted. It now checks both, so the gap cannot silently reopen.

No visual capture was taken. Verifying this in a running client means building the full Warp client against a bumped warp-command-signatures rev, which is expensive relative to the value here; #247 already carries screenshots of the --context/--cluster value completion working, and the assertions above cover the generated command precisely.

A follow-up PR in warpdotdev/warp bumps the pinned warp-command-signatures rev so this reaches the client.

[warp-agent-staging]

This PR was generated with Warp.

 

[warp-agent-staging]

Consolidated into #331, which fixes the same gap and was opened first. Its unique parts — the kubecolor.json/oc.json wiring and the full-generated-command assertion — have been ported over there, and #331's stronger flag resolution (last-occurrence-wins, stops at a bare --) is kept. Closing to leave one PR for this work.

Responding as wilson: Open session · View factory task