[Completions] Bump command-signatures to 15debaeb (kubectl --context/--cluster/--user forwarding) - #15109
Merged
Merged
Conversation
Contributor
Author
|
This PR was generated with Warp. |
warp-agent-staging
Bot
force-pushed
the
factory/app-46-bump-command-signatures
branch
from
August 13, 2026 23:31
1ef9f06 to
e6e897f
Compare
warp-agent-staging
Bot
force-pushed
the
factory/app-46-bump-command-signatures
branch
from
August 13, 2026 23:44
e6e897f to
8e14819
Compare
warp-agent-staging
Bot
force-pushed
the
factory/app-46-bump-command-signatures
branch
from
August 14, 2026 00:15
8e14819 to
98766e1
Compare
warp-agent-staging
Bot
force-pushed
the
factory/app-46-bump-command-signatures
branch
from
August 14, 2026 00:36
98766e1 to
9ff75c9
Compare
acarl005
marked this pull request as ready for review
August 14, 2026 00:51
Merged PRs: - Fix nx run completions: use nx graph --file=stdout (warpdotdev/command-signatures#335) - Add completion specs for yay and paru (AUR helpers) (warpdotdev/command-signatures#334) - Fix yay/paru completion specs: -Pc field separators and -B/--build option placement (warpdotdev/command-signatures#336) - Forward --context/--cluster/--user in kubectl generators (warpdotdev/command-signatures#331) The kubectl change forwards a --context, --cluster or --user written on the command line into the commands the completion generators run. Without it, completions after a --context enumerated from the shell's active context instead of the one on the line (#5186, #3929). It also adds --user value completions and wires --context/--cluster/--user up for kubecolor and oc. Co-Authored-By: Warp Agent <agent@warp.dev>
warp-agent-staging
Bot
force-pushed
the
factory/app-46-bump-command-signatures
branch
from
August 14, 2026 00:52
9ff75c9 to
b6f31f0
Compare
acarl005
approved these changes
Aug 14, 2026
acarl005
enabled auto-merge (squash)
August 14, 2026 00:53
This was referenced Aug 14, 2026
acarl005
pushed a commit
that referenced
this pull request
Aug 14, 2026
…onciliation) (#15159) ## Description Bumps the `warp-command-signatures` git dependency to `d79e09c43b64eb8e55a81fec088423aeba6a48cd`, the current `main` of `warpdotdev/command-signatures`. This brings in warpdotdev/command-signatures#337, which reconciles `paru.json` against the real paru v2.1.0 CLI (audited against paru's own argument parser source, not just `--help`/the man page). `yay`/`paru` completions themselves already shipped in the prior pin bump (#15109); this is a spec correction on top — `paru` completions now describe options, operations, and argument types that match what paru v2.1.0 actually accepts, instead of the stale surface reflected by paru's shipped fish-completion script. Tracked by APP-5390. ## Linked Issue - [x] N/A — this is a dependency pin bump following on from #5177, not a new implementation against a tracked issue. ## Testing This is a data-only dependency bump (JSON completion spec changes in the upstream repo; no Rust code changed there between the old and new pin). Verified via: - `git diff <old-rev> <new-rev> --stat` in `command-signatures`, confirming the only change between the two pins is `command-signatures/json/paru.json`. - `cargo metadata --locked --format-version 1` in this repo, which succeeds with the new rev and confirms `Cargo.lock` is fully consistent with `Cargo.toml` (no other dependency drift). - [ ] I have manually tested my changes locally with `./script/run` Not manually tested end-to-end in a running Warp session (no computer-use/GUI access available). The underlying spec change was verified in warpdotdev/command-signatures#337 by building `paru` from the AUR in a container and checking its output against the new spec. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode <!-- CHANGELOG-IMPROVEMENT: Corrected `paru` completions to match the current paru v2.1.0 CLI. --> Co-authored-by: warp-agent-staging[bot] <240773466+warp-agent-staging[bot]@users.noreply.github.com> Co-authored-by: Warp Agent <agent@warp.dev>
iamwavecut
pushed a commit
to iamwavecut/warp
that referenced
this pull request
Aug 15, 2026
…onciliation) (warpdotdev#15159) ## Description Bumps the `warp-command-signatures` git dependency to `d79e09c43b64eb8e55a81fec088423aeba6a48cd`, the current `main` of `warpdotdev/command-signatures`. This brings in warpdotdev/command-signatures#337, which reconciles `paru.json` against the real paru v2.1.0 CLI (audited against paru's own argument parser source, not just `--help`/the man page). `yay`/`paru` completions themselves already shipped in the prior pin bump (warpdotdev#15109); this is a spec correction on top — `paru` completions now describe options, operations, and argument types that match what paru v2.1.0 actually accepts, instead of the stale surface reflected by paru's shipped fish-completion script. Tracked by APP-5390. ## Linked Issue - [x] N/A — this is a dependency pin bump following on from warpdotdev#5177, not a new implementation against a tracked issue. ## Testing This is a data-only dependency bump (JSON completion spec changes in the upstream repo; no Rust code changed there between the old and new pin). Verified via: - `git diff <old-rev> <new-rev> --stat` in `command-signatures`, confirming the only change between the two pins is `command-signatures/json/paru.json`. - `cargo metadata --locked --format-version 1` in this repo, which succeeds with the new rev and confirms `Cargo.lock` is fully consistent with `Cargo.toml` (no other dependency drift). - [ ] I have manually tested my changes locally with `./script/run` Not manually tested end-to-end in a running Warp session (no computer-use/GUI access available). The underlying spec change was verified in warpdotdev/command-signatures#337 by building `paru` from the AUR in a container and checking its output against the new spec. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode <!-- CHANGELOG-IMPROVEMENT: Corrected `paru` completions to match the current paru v2.1.0 CLI. --> Co-authored-by: warp-agent-staging[bot] <240773466+warp-agent-staging[bot]@users.noreply.github.com> Co-authored-by: Warp Agent <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Updates
warp-command-signaturesto15debaeb, the squash commit oncommand-signatures:mainfor warpdotdev/command-signatures#331.That PR fixes the last remaining symptom of #5186: a
--context(or--cluster, or--user) written on the command line was never forwarded into the commands the kubectl completion generators run, so later completions enumerated from the shell's active context instead of the one on the line. Withkubectl --context staging-cluster --namespace <TAB>, the generator rankubectl … get namespace -o custom-columns=:.metadata.namewith no--context. It now forwards--context,--clusterand--user, mirroring the existing--kubeconfigand--namespacehandling. It also adds value completion forkubectl --user, and wires--context/--cluster/--userup forkubecolorandoc, which declared those options with no generator.Merged PRs
Linked Issue
Addresses #5186 (labeled
ready-to-implement). Also addresses #3929, which asks for this same context-forwarding behavior. Deliberately no closing keyword — #5186 covers several symptoms and should be closed manually with a note that the earlier parts landed in the June 2026 stable builds.ready-to-specorready-to-implement.Testing
The kubectl behavior is covered by unit tests in warpdotdev/command-signatures#331, which assert the generated command string rather than merely that completion happens — including an
assert_eqon the entire command for the reported case, and a tightenedtest_context_and_namespace_flags_before_subcommand(it previously passed a--contextbut only checked namespace forwarding, which is why the earlier #247 fix missed this). That repo's./script/presubmitand CI were green on merge: 174 tests, 33 of them kubectl-specific.For this dependency bump:
cargo fmt --all --checkpasses.cargo clippy -p warp_completer --all-targets --tests -- -D warningspasses against the new rev.cargo metadata --lockedaccepts the lockfile, soCargo.lockis in sync; the lockfile diff is limited to the twocommand-signaturessource lines.cargo tree -p warp_completer -i warp-command-signaturesconfirms15debaebis what resolves.cargo test -p warp_completerreports 138 passed / 25 failed, identical toorigin/masterwith this change stashed. Those 25 failures are pre-existing in this environment and unrelated to the bump. There are no kubectl-specific tests inwarp_completer.I have manually tested my changes locally with
./script/runScreenshots / Videos
No capture taken. Exercising this path in a running client requires a full client build against the bumped rev, which is expensive relative to the value: warpdotdev/command-signatures#247 already carries screenshots of the
--context/--clustervalue completion working, #331 carries end-to-end evidence from realkubectlruns against a synthetic offline kubeconfig, and the generated command is asserted precisely by unit tests.Agent Mode
CHANGELOG-IMPROVEMENT: Added completions for
yayandparu, andkubectl --uservalue completions.CHANGELOG-BUG-FIX: Fixed
kubectlcompletions ignoring a--context,--clusteror--userwritten on the command line, so namespaces, pods and other resources are now suggested from that cluster instead of the shell's active context.kubecolorandocnow complete those flags too, andnx runcompletions were fixed.