Skip to content

[Completions] Bump command-signatures to 15debaeb (kubectl --context/--cluster/--user forwarding) - #15109

Merged
acarl005 merged 1 commit into
masterfrom
factory/app-46-bump-command-signatures
Aug 14, 2026
Merged

[Completions] Bump command-signatures to 15debaeb (kubectl --context/--cluster/--user forwarding)#15109
acarl005 merged 1 commit into
masterfrom
factory/app-46-bump-command-signatures

Conversation

@warp-agent-staging

@warp-agent-staging warp-agent-staging Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Description

Updates warp-command-signatures to 15debaeb, the squash commit on command-signatures:main for warpdotdev/command-signatures#331.

That PR fixes the last remaining symptom of #5186: a --context (or --cluster, or --user) written on the command line was never forwarded into the commands the kubectl completion generators run, so later completions enumerated from the shell's active context instead of the one on the line. With kubectl --context staging-cluster --namespace <TAB>, the generator ran kubectl … get namespace -o custom-columns=:.metadata.name with no --context. It now forwards --context, --cluster and --user, mirroring the existing --kubeconfig and --namespace handling. It also adds value completion for kubectl --user, and wires --context/--cluster/--user up for kubecolor and oc, which declared those options with no generator.

Merged PRs

Linked Issue

Addresses #5186 (labeled ready-to-implement). Also addresses #3929, which asks for this same context-forwarding behavior. Deliberately no closing keyword — #5186 covers several symptoms and should be closed manually with a note that the earlier parts landed in the June 2026 stable builds.

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

The kubectl behavior is covered by unit tests in warpdotdev/command-signatures#331, which assert the generated command string rather than merely that completion happens — including an assert_eq on the entire command for the reported case, and a tightened test_context_and_namespace_flags_before_subcommand (it previously passed a --context but only checked namespace forwarding, which is why the earlier #247 fix missed this). That repo's ./script/presubmit and CI were green on merge: 174 tests, 33 of them kubectl-specific.

For this dependency bump:

  • cargo fmt --all --check passes.

  • cargo clippy -p warp_completer --all-targets --tests -- -D warnings passes against the new rev.

  • cargo metadata --locked accepts the lockfile, so Cargo.lock is in sync; the lockfile diff is limited to the two command-signatures source lines.

  • cargo tree -p warp_completer -i warp-command-signatures confirms 15debaeb is what resolves.

  • cargo test -p warp_completer reports 138 passed / 25 failed, identical to origin/master with this change stashed. Those 25 failures are pre-existing in this environment and unrelated to the bump. There are no kubectl-specific tests in warp_completer.

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

No capture taken. Exercising this path in a running client requires a full client build against the bumped rev, which is expensive relative to the value: warpdotdev/command-signatures#247 already carries screenshots of the --context/--cluster value completion working, #331 carries end-to-end evidence from real kubectl runs against a synthetic offline kubeconfig, and the generated command is asserted precisely by unit tests.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-IMPROVEMENT: Added completions for yay and paru, and kubectl --user value completions.
CHANGELOG-BUG-FIX: Fixed kubectl completions ignoring a --context, --cluster or --user written on the command line, so namespaces, pods and other resources are now suggested from that cluster instead of the shell's active context. kubecolor and oc now complete those flags too, and nx run completions were fixed.

@warp-agent-staging

Copy link
Copy Markdown
Contributor Author

This PR was generated with Warp.

View run View conversation

@warp-agent-staging
warp-agent-staging Bot force-pushed the factory/app-46-bump-command-signatures branch from 1ef9f06 to e6e897f Compare August 13, 2026 23:31
@warp-agent-staging warp-agent-staging Bot changed the title [Completions] Bump command-signatures to 24f7cca4 (kubectl --context forwarding) [Completions] Bump command-signatures to c85b0a99 (kubectl --context forwarding) Aug 13, 2026
@warp-agent-staging
warp-agent-staging Bot force-pushed the factory/app-46-bump-command-signatures branch from e6e897f to 8e14819 Compare August 13, 2026 23:44
@warp-agent-staging warp-agent-staging Bot changed the title [Completions] Bump command-signatures to c85b0a99 (kubectl --context forwarding) [Completions] Bump command-signatures to e498c4bd (kubectl --context/--cluster/--user forwarding) Aug 13, 2026
@warp-agent-staging
warp-agent-staging Bot force-pushed the factory/app-46-bump-command-signatures branch from 8e14819 to 98766e1 Compare August 14, 2026 00:15
@warp-agent-staging warp-agent-staging Bot changed the title [Completions] Bump command-signatures to e498c4bd (kubectl --context/--cluster/--user forwarding) [Completions] Bump command-signatures to 807e87bb (kubectl --context/--cluster/--user forwarding) Aug 14, 2026
@warp-agent-staging warp-agent-staging Bot changed the title [Completions] Bump command-signatures to 807e87bb (kubectl --context/--cluster/--user forwarding) [Completions] Bump command-signatures to 8d33ac92 (kubectl --context/--cluster/--user forwarding) Aug 14, 2026
@warp-agent-staging
warp-agent-staging Bot force-pushed the factory/app-46-bump-command-signatures branch from 98766e1 to 9ff75c9 Compare August 14, 2026 00:36
@acarl005
acarl005 marked this pull request as ready for review August 14, 2026 00:51
Merged PRs:
- Fix nx run completions: use nx graph --file=stdout (warpdotdev/command-signatures#335)
- Add completion specs for yay and paru (AUR helpers) (warpdotdev/command-signatures#334)
- Fix yay/paru completion specs: -Pc field separators and -B/--build option
  placement (warpdotdev/command-signatures#336)
- Forward --context/--cluster/--user in kubectl generators (warpdotdev/command-signatures#331)

The kubectl change forwards a --context, --cluster or --user written on
the command line into the commands the completion generators run.
Without it, completions after a --context enumerated from the shell's
active context instead of the one on the line (#5186,
#3929). It also adds --user value completions and wires
--context/--cluster/--user up for kubecolor and oc.

Co-Authored-By: Warp Agent <agent@warp.dev>
@warp-agent-staging warp-agent-staging Bot changed the title [Completions] Bump command-signatures to 8d33ac92 (kubectl --context/--cluster/--user forwarding) [Completions] Bump command-signatures to 15debaeb (kubectl --context/--cluster/--user forwarding) Aug 14, 2026
@warp-agent-staging
warp-agent-staging Bot force-pushed the factory/app-46-bump-command-signatures branch from 9ff75c9 to b6f31f0 Compare August 14, 2026 00:52
@acarl005
acarl005 enabled auto-merge (squash) August 14, 2026 00:53
@acarl005
acarl005 merged commit 59bda8d into master Aug 14, 2026
27 checks passed
@acarl005
acarl005 deleted the factory/app-46-bump-command-signatures branch August 14, 2026 01:13
acarl005 pushed a commit that referenced this pull request Aug 14, 2026
…onciliation) (#15159)

## Description

Bumps the `warp-command-signatures` git dependency to
`d79e09c43b64eb8e55a81fec088423aeba6a48cd`, the current `main` of
`warpdotdev/command-signatures`.

This brings in warpdotdev/command-signatures#337, which reconciles
`paru.json` against the real paru v2.1.0 CLI (audited against paru's own
argument parser source, not just `--help`/the man page). `yay`/`paru`
completions themselves already shipped in the prior pin bump (#15109);
this is a spec correction on top — `paru` completions now describe
options, operations, and argument types that match what paru v2.1.0
actually accepts, instead of the stale surface reflected by paru's
shipped fish-completion script.

Tracked by APP-5390.

## Linked Issue

- [x] N/A — this is a dependency pin bump following on from
#5177, not a new implementation against a tracked issue.

## Testing

This is a data-only dependency bump (JSON completion spec changes in the
upstream repo; no Rust code changed there between the old and new pin).
Verified via:
- `git diff <old-rev> <new-rev> --stat` in `command-signatures`,
confirming the only change between the two pins is
`command-signatures/json/paru.json`.
- `cargo metadata --locked --format-version 1` in this repo, which
succeeds with the new rev and confirms `Cargo.lock` is fully consistent
with `Cargo.toml` (no other dependency drift).

- [ ] I have manually tested my changes locally with `./script/run`

Not manually tested end-to-end in a running Warp session (no
computer-use/GUI access available). The underlying spec change was
verified in warpdotdev/command-signatures#337 by building `paru` from
the AUR in a container and checking its output against the new spec.

## Agent Mode
- [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode

<!--
CHANGELOG-IMPROVEMENT: Corrected `paru` completions to match the current
paru v2.1.0 CLI.
-->

Co-authored-by: warp-agent-staging[bot] <240773466+warp-agent-staging[bot]@users.noreply.github.com>
Co-authored-by: Warp Agent <agent@warp.dev>
iamwavecut pushed a commit to iamwavecut/warp that referenced this pull request Aug 15, 2026
…onciliation) (warpdotdev#15159)

## Description

Bumps the `warp-command-signatures` git dependency to
`d79e09c43b64eb8e55a81fec088423aeba6a48cd`, the current `main` of
`warpdotdev/command-signatures`.

This brings in warpdotdev/command-signatures#337, which reconciles
`paru.json` against the real paru v2.1.0 CLI (audited against paru's own
argument parser source, not just `--help`/the man page). `yay`/`paru`
completions themselves already shipped in the prior pin bump (warpdotdev#15109);
this is a spec correction on top — `paru` completions now describe
options, operations, and argument types that match what paru v2.1.0
actually accepts, instead of the stale surface reflected by paru's
shipped fish-completion script.

Tracked by APP-5390.

## Linked Issue

- [x] N/A — this is a dependency pin bump following on from
warpdotdev#5177, not a new implementation against a tracked issue.

## Testing

This is a data-only dependency bump (JSON completion spec changes in the
upstream repo; no Rust code changed there between the old and new pin).
Verified via:
- `git diff <old-rev> <new-rev> --stat` in `command-signatures`,
confirming the only change between the two pins is
`command-signatures/json/paru.json`.
- `cargo metadata --locked --format-version 1` in this repo, which
succeeds with the new rev and confirms `Cargo.lock` is fully consistent
with `Cargo.toml` (no other dependency drift).

- [ ] I have manually tested my changes locally with `./script/run`

Not manually tested end-to-end in a running Warp session (no
computer-use/GUI access available). The underlying spec change was
verified in warpdotdev/command-signatures#337 by building `paru` from
the AUR in a container and checking its output against the new spec.

## Agent Mode
- [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode

<!--
CHANGELOG-IMPROVEMENT: Corrected `paru` completions to match the current
paru v2.1.0 CLI.
-->

Co-authored-by: warp-agent-staging[bot] <240773466+warp-agent-staging[bot]@users.noreply.github.com>
Co-authored-by: Warp Agent <agent@warp.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants