feat(docs): replace native title= attributes with Tooltip component (#495) - #642
Conversation
…uetifyjs#495) Replace native HTML title= attributes in docs app components with the Tooltip.Root / Tooltip.Activator / Tooltip.Content compound component: - DocsExample.vue: 5 icon buttons (Reset, Open in Playground, Open in Bin, Combine/Split) converted from title= to Tooltip wrappers - AppSettings.vue: Settings button — button replaced with Tooltip.Activator (renders as button) - AppAccount.vue: Sign-in button wrapped in Tooltip.Root; Account settings button inside Discovery.Activator uses renderless Tooltip.Activator pattern to spread hover/focus attrs - AppSkillFilter.vue: Popover.Activator wrapped via renderless Tooltip.Activator inside Popover.Root - AppBar.vue: Search, Discord, and GitHub elements already had aria-label; native title= removed
|
This PR currently has merge conflicts with its base branch ( Context: we're adopting a git-flow branch model — |
|
Thanks for the work here, and apologies for the overlap. Closing this — it's been superseded. The day after these PRs were opened, #621 landed and closed #495 by introducing a reusable
One thing worth carrying forward regardless: If you'd like to keep contributing to this area, the remaining un-migrated spots are the |
Summary
Continues the #495 migration by replacing native
title=HTML attributes inapps/docswith theTooltip.Root / Tooltip.Activator / Tooltip.Contentcompound component, following the same patterns already applied toapps/playgroundin #637.Tooltipadded to importsTooltip.Activator(which renders as<button>by default);Tooltipadded to importsTooltip.Root; Account settings button (insideDiscovery.Activator) uses the renderlessTooltip.Activatorpattern to spread hover/focus/aria-describedbyattrs onto the native button;Tooltipadded to importsPopover.Activator(insidePopover.Root) wrapped via renderlessTooltip.Activator;Tooltipadded to importsaria-label; redundanttitle=attributes removedTooltip.Content styling
All new
Tooltip.Contentelements useclass="px-2.5 py-1.5 rounded border border-divider text-xs bg-surface text-on-surface shadow-lg", matching the pattern established inDocsMaturity.vue.Not included
Dynamic
title=bindings inDocsCodeActions.vue,DocsAskPanel.vue,DocsSearch.vue,AppSettingsSheet.vue, and others — those have more complex patterns (dynamic text, third-partyGnActionButton) and will be addressed in follow-up PRs.Closes part of #495