feat(docs): replace remaining native title= attributes with Tooltip (#495) - #643
feat(docs): replace remaining native title= attributes with Tooltip (#495)#643sridhar-3009 wants to merge 1 commit into
Conversation
…uetifyjs#495) Continue the vuetifyjs#495 migration for the remaining docs components: - DocsAskPanel.vue: 4 icon buttons (Open in Bin, Copy conversation, Reset conversation, Fullscreen toggle) converted to Tooltip wrappers - DocsExampleCodePane.vue: 'Collapse code' button wrapped in Tooltip - DocsCodeActions.vue: 5 GnActionButton instances wrapped via renderless Tooltip.Activator (spreads hover/focus attrs through inheritAttrs) - AppSettingsSheet.vue: Sign out button replaced with Tooltip.Activator - AppSettingsTheme.vue: Copy theme button wrapped in Tooltip - AppThemeCustomButton.vue: Edit theme button wrapped in Tooltip - HomeInstallCommand.vue: Popover.Activator for package manager wrapped via renderless Tooltip.Activator inside Popover.Root - AppSearchInline.vue: redundant title= removed (button already has aria-label and visible text content)
|
This PR currently has merge conflicts with its base branch ( Context: we're adopting a git-flow branch model — |
|
Thanks for the work here, and apologies for the overlap. Closing this — it's been superseded. The day after these PRs were opened, #621 landed and closed #495 by introducing a reusable
One thing worth carrying forward regardless: If you'd like to keep contributing to this area, the remaining un-migrated spots are the |
Summary
Continues the #495 migration (see also #642) for the remaining
apps/docscomponents with nativetitle=HTML attributes.DocsAskPanel.vueTooltip.Root / Tooltip.Activator / Tooltip.ContentDocsExampleCodePane.vueTooltip.Root / Tooltip.ActivatorDocsCodeActions.vueGnActionButtoninstances wrapped via renderlessTooltip.Activator(spreadsonPointerenter,onFocus,aria-describedbythroughinheritAttrs);title=removedAppSettingsSheet.vueTooltip.ActivatorAppSettingsTheme.vueTooltip.Root / Tooltip.ActivatorAppThemeCustomButton.vueTooltip.Root / Tooltip.ActivatorHomeInstallCommand.vuePopover.Activator(insidePopover.Root) wrapped via renderlessTooltip.ActivatorAppSearchInline.vuetitle=removed (button hasaria-labeland visible "Search the docs…" text)Closes part of #495 (remaining:
DocsSearch.vuewhich has 9 dynamictitle=bindings across complex list items)