fix(cli): resolve Windows shims in case-sensitive directories

.github/workflows/ci.yml

@@ -1102,6 +1102,17 @@ jobs:
         with:
           tool: cargo-nextest
 
+      # Keep fixtures outside runner.temp: setup-node writes an .npmrc there,
+      # which Yarn Classic discovers when walking parent directories.
+      - name: Create NTFS snapshot temp directory
+        id: snapshot-temp
+        shell: pwsh
+        run: |
+          $volume = [System.IO.Path]::GetPathRoot($env:RUNNER_TEMP)
+          $snapshotTemp = Join-Path $volume ('vp-snapshots-' + [guid]::NewGuid().ToString('N'))
+          New-Item -ItemType Directory -Path $snapshotTemp | Out-Null
+          "directory=$snapshotTemp" >> $env:GITHUB_OUTPUT
+
       # `cargo-nextest` is invoked directly so the job never depends on the
       # runner's Rust toolchain. --workspace-remap makes nextest rewrite
       # CARGO_MANIFEST_DIR and CARGO_BIN_EXE_vpt to this checkout, which is
@@ -1124,6 +1135,10 @@ jobs:
           cargo-nextest nextest run --archive-file windows-snapshot-tests.tar.zst --workspace-remap . --no-fail-fast --partition hash:${{ matrix.shard }}/3
         env:
           RUST_BACKTRACE: '1'
+          # Rust's GetTempPath2 ignores TEMP/TMP under the SYSTEM account.
+          # Use the runner's NTFS workspace volume: C:\Windows\SystemTemp
+          # rejects the case-sensitive directory flag on these hosts.
+          SystemTemp: ${{ steps.snapshot-temp.outputs.directory }}
           # Keep Windows env parity with the `test` recipe in justfile.
           __COMPAT_LAYER: RunAsInvoker
 

Cargo.toml

@@ -400,6 +400,11 @@ rolldown_watcher = { path = "./rolldown/crates/rolldown_watcher" }
 rolldown_workspace = { path = "./rolldown/crates/rolldown_workspace" }
 string_wizard = { path = "./rolldown/crates/string_wizard", features = ["serde"] }
 
+[patch.crates-io]
+# Resolve Windows shims in case-sensitive directories for all which callers.
+# Remove this patch after https://github.com/harryfei/which-rs/pull/131 is released.
+which = { git = "https://github.com/fengmk2/which-rs.git", rev = "4f6f1b81b23f2887409bf838f4369690f9c2e336" }
+
 # =============================================================================
 # Local Development Patches
 # =============================================================================

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/later-shim.cjs

@@ -0,0 +1,4 @@
+const fs = require('node:fs');
+
+fs.mkdirSync('node_modules/.bin', { recursive: true });
+fs.writeFileSync('node_modules/.bin/astro.CMD', '@echo wrong workspace shim %*\r\n');

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "case-sensitive-shims",
+  "private": true,
+  "packageManager": "pnpm@12.4.1",
+  "scripts": {
+    "probe": "vp run --filter @fixture/app probe"
+  }
+}

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/packages/app/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "@fixture/app",
+  "private": true,
+  "scripts": {
+    "probe": "astro --version"
+  }
+}

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/packages/app/print.cjs

@@ -0,0 +1 @@
+console.log('local shim', ...process.argv.slice(2));

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/packages/app/vite.config.ts

@@ -0,0 +1,9 @@
+export default {
+  run: {
+    tasks: {
+      cached: {
+        command: "astro cached",
+      },
+    },
+  },
+};

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/pnpm-workspace.yaml

@@ -0,0 +1,2 @@
+packages:
+  - packages/*

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/setup.cjs

@@ -0,0 +1,13 @@
+const assert = require('node:assert/strict');
+const { execFileSync } = require('node:child_process');
+const fs = require('node:fs');
+const path = require('node:path');
+
+const bin = path.resolve('packages/app/node_modules/.bin');
+fs.mkdirSync(bin, { recursive: true });
+// The directory must be empty when case sensitivity is enabled. Do not depend
+// on the checkout's NTFS flags or the casing chosen by a package manager.
+execFileSync('fsutil.exe', ['file', 'setCaseSensitiveInfo', bin, 'enable'], { stdio: 'inherit' });
+fs.writeFileSync(path.join(bin, 'astro.cmd'), '@echo off\r\nnode "%~dp0/../../print.cjs" %*\r\n');
+assert.equal(fs.existsSync(path.join(bin, 'astro.CMD')), false);
+assert.equal(process.env.PATHEXT, '.COM;.EXE;.BAT;.CMD');

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/snapshots.toml

@@ -0,0 +1,15 @@
+[[case]]
+name = "windows_case_sensitive_shims"
+vp = ["local", "global"]
+skip-platforms = ["linux", "macos"]
+env = { PATHEXT = ".COM;.EXE;.BAT;.CMD" }
+steps = [
+  { argv = ["node", "setup.cjs"], snapshot = false },
+  { argv = ["vp", "run", "probe"], tty = false, comment = "Nested task planning resolves the lowercase shim with uppercase PATHEXT." },
+  { argv = ["vp", "exec", "astro", "--version"], cwd = "packages/app", tty = false },
+  { argv = ["node", "later-shim.cjs"], snapshot = false },
+  { argv = ["vp", "run", "probe"], tty = false, comment = "The earlier package-local lowercase shim wins over a later uppercase shim." },
+  { argv = ["vp", "exec", "astro", "--version"], cwd = "packages/app", tty = false },
+  { argv = ["vp", "run", "cached"], cwd = "packages/app", tty = false },
+  { argv = ["vp", "run", "cached"], cwd = "packages/app", tty = false, comment = "Resolving the program keeps the task's cache behavior." },
+]

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/snapshots/windows_case_sensitive_shims.global.md

@@ -0,0 +1,56 @@
+# windows_case_sensitive_shims
+
+## `node setup.cjs`
+
+
+## `vp run probe`
+
+Nested task planning resolves the lowercase shim with uppercase PATHEXT.
+
+```
+~/packages/app$ astro --version ⊘ cache disabled
+local shim --version
+```
+
+## `cd packages/app && vp exec astro --version`
+
+```
+local shim --version
+```
+
+## `node later-shim.cjs`
+
+
+## `vp run probe`
+
+The earlier package-local lowercase shim wins over a later uppercase shim.
+
+```
+~/packages/app$ astro --version ⊘ cache disabled
+local shim --version
+```
+
+## `cd packages/app && vp exec astro --version`
+
+```
+local shim --version
+```
+
+## `cd packages/app && vp run cached`
+
+```
+~/packages/app$ astro cached
+local shim cached
+```
+
+## `cd packages/app && vp run cached`
+
+Resolving the program keeps the task's cache behavior.
+
+```
+~/packages/app$ astro cached ◉ cache hit, replaying
+local shim cached
+
+---
+vp run: cache hit, <duration> saved.
+```

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/snapshots/windows_case_sensitive_shims.local.md

@@ -0,0 +1,56 @@
+# windows_case_sensitive_shims
+
+## `node setup.cjs`
+
+
+## `vp run probe`
+
+Nested task planning resolves the lowercase shim with uppercase PATHEXT.
+
+```
+~/packages/app$ astro --version ⊘ cache disabled
+local shim --version
+```
+
+## `cd packages/app && vp exec astro --version`
+
+```
+local shim --version
+```
+
+## `node later-shim.cjs`
+
+
+## `vp run probe`
+
+The earlier package-local lowercase shim wins over a later uppercase shim.
+
+```
+~/packages/app$ astro --version ⊘ cache disabled
+local shim --version
+```
+
+## `cd packages/app && vp exec astro --version`
+
+```
+local shim --version
+```
+
+## `cd packages/app && vp run cached`
+
+```
+~/packages/app$ astro cached
+local shim cached
+```
+
+## `cd packages/app && vp run cached`
+
+Resolving the program keeps the task's cache behavior.
+
+```
+~/packages/app$ astro cached ◉ cache hit, replaying
+local shim cached
+
+---
+vp run: cache hit, <duration> saved.
+```