Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://codex-fix-windows-pnpm12-shims-viteplus-dev.voidzero-docs.workers.dev (commit 201da27)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Contributor
CLI artifact sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
packages/cli/dist |
Directory total | 2.15 MiB | 2.15 MiB | 0 B (0.00%) |
packages/core/dist |
Directory total | 3.95 MiB | 3.95 MiB | 0 B (0.00%) |
| Combined package dist | Directory total | 6.09 MiB | 6.09 MiB | 0 B (0.00%) |
vp (Linux x64) |
Binary | 11.18 MiB | 11.18 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.84 MiB | 4.84 MiB | -1 B (-0.00%) |
| NAPI (Linux x64) | Binary | 32.01 MiB | 32.01 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.69 MiB | 12.69 MiB | -2 B (-0.00%) |
vp (macOS ARM64) |
Binary | 8.33 MiB | 8.33 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 4.22 MiB | 4.22 MiB | -6 B (-0.00%) |
| NAPI (macOS ARM64) | Binary | 39.64 MiB | 39.64 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 17.01 MiB | 17.01 MiB | +1 B (+0.00%) |
vp (Windows x64) |
Binary | 9.06 MiB | 9.04 MiB | -26.50 KiB (-0.29%) |
vp (Windows x64) |
gzip -9 | 3.96 MiB | 3.95 MiB | -11.51 KiB (-0.28%) |
| NAPI (Windows x64) | Binary | 26.98 MiB | 26.95 MiB | -26.00 KiB (-0.09%) |
| NAPI (Windows x64) | gzip -9 | 10.80 MiB | 10.79 MiB | -14.65 KiB (-0.13%) |
| Trampoline (Windows x64) | Binary | 13.50 KiB | 13.50 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 7.03 KiB | 7.03 KiB | 0 B (0.00%) |
| Installer (Windows x64) | Binary | 4.53 MiB | 4.53 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.12 MiB | 2.12 MiB | +2 B (+0.00%) |
fengmk2
force-pushed
the
codex/fix-windows-pnpm12-shims
branch
from
September 16, 2026 17:51
999f317 to
4ef9e6b
Compare
fengmk2
force-pushed
the
codex/fix-windows-pnpm12-shims
branch
from
September 16, 2026 17:54
4ef9e6b to
201da27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2690.
On Windows, pnpm 12 writes lowercase
.cmdshims. In a case-sensitivenode_modules/.bindirectory,PATHEXT=.COM;.EXE;.BAT;.CMDmakeswhichcheckastro.CMDbefore correcting filename casing, sovp runfails to plan the task andvp exec astroreports that the command is missing.Resolve Windows executable candidates using their actual filename casing in
vp_command, preserving PATH and PATHEXT precedence. Use Vite+'s existing mutable command-handler hook to supply the resolved path before Vite Task's own lookup. This fixes nested tasks and direct execution entirely within Vite+, without dependency changes or PATHEXT mutation.The Windows snapshot job sets
SystemTempto an isolated directory on the runner's NTFS workspace volume, outsiderunner.tempso Yarn does not inherit setup-node's.npmrc. Rust usesGetTempPath2, which ignores the existingTEMP/TMPoverrides under SYSTEM; the runner's defaultC:\Windows\SystemTemprejects case-sensitive directory flags, while its workspace volume supports them.Validation
CI passed on commit
999f317b, including all three Windows snapshot shards and both case-sensitive shim entrypoints.Reproduced the failure with published Vite+ 0.3.2, pnpm 12.4.1, and Astro 7.3.2 in a case-sensitive Windows directory. With the compiled fix, the unchanged nested task and
vp execboth run Astro successfully.cargo test -p vp_command -p vite-plus-cli --lib --locked: 91 tests passed, including 10 new resolver/handler tests.Focused Clippy for both crates, all targets and the
rolldownfeature, passed with warnings denied and the repository's existing upstream lint allowances.Built the native CLI with the
rolldownfeature, the global CLI, and the Windows trampoline.New CLI snapshots passed in record and compare modes for both local and global entrypoints. They create a genuinely case-sensitive
.bindirectory and cover nested planning, direct exec, a later uppercase shim, and cache replay.Rust formatting and
git diff --checkpassed.Local validation ran on Windows ARM64 with Node 24.20.0. CLI integration used the branch's compiled Rust binaries with the published 0.3.2 JavaScript artifacts; a full
pnpm buildand the full repository test suite were not run.