deps: upgrade devframe to v0.9.11 - #560
Closed
antfubot wants to merge 2 commits into
Closed
Conversation
devframe 0.9.11 records the resolveFrom each static dir was mounted with on ctx.views.buildStaticDirs. A plugin devframe's remote --assets bundle (inspect, messages) must re-resolve against that plugin's own importMetaUrl to hit the locally-installed copy; without it resolution falls back to the back-proxy CDN cache and bakes a stale SPA. Thread resolveFrom through, mirroring the hub's own buildHub copyBuildStatics.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades devframe (and every
@devframes/*package) from^0.9.10to^0.9.11via the shared catalog ref, and aligns the static builder with devframe 0.9.11'sbuildHub.What 0.9.11 brings. devframes/devframe#349 (closing the issue this repo filed, devframes/devframe#347) reworked
buildHubto accept an already-mountedcontext— the intent being that Vite DevTools could delete its hand-rolledpackages/core/src/node/build-static.tsand reuse the hub's baker.Why we can't drop
build-static.tsontobuildHub({ context })yet.buildHubbakes the whole hub as a single subtree under onebase: itsresolveOutPaththrowsDF8006for any static dir or served frame whose URL doesn't start withbase. Vite DevTools serves the hub UI at/__devtools/but mounts each built-in devframe SPA at a root-level sibling (/__devframes_plugin_inspect/,/__devframes_plugin_messages/, …) and the vendored assets at/__devtools-assets/— none under/__devtools/. SocopyBuildStaticswould throw on the first sibling entry. Full adoption needs either an upstreambuildHubthat bakes statics/frames living outside the hub base (a deploy-root layout), or restructuring Vite DevTools to nest every devframe + asset under/__devtools/(a dev- and build-mode serving change). Tracking that separately.What this PR does align. 0.9.11 records the
resolveFromeach static dir was mounted with onctx.views.buildStaticDirs, andbuildHub'scopyBuildStaticsthreads it throughresolveStaticAssetsSource. Our builder ignored it, so a plugin devframe's remote--assetsbundle (inspect, messages) re-resolved against core's back-proxy CDN cache and could bake a stale SPA.build-static.tsnow threadsresolveFrom, mirroringbuildHuband fixing the latent stale-SPA bug.Verified with a real
cli build: statics resolve to the locally-installed plugin copies and the frame SPAs bake correctly.pnpm typecheck && pnpm test && pnpm lint && pnpm buildall pass.Linked Issues
Relates to devframes/devframe#347 / devframes/devframe#349.
Additional context
The residual
0.9.10/0.8.2@devframes/*entries inpnpm-lock.yamlcome from the published@vitejs/devtools@0.5.2pulled in transitively by a fixture — pre-existing, unrelated to this bump; the workspace packages all resolve to0.9.11.This PR was created with the help of an agent.