deps: upgrade devframe to v0.9.12 + bake static build through buildHub - #561
Merged
Conversation
devframe 0.9.12 (devframes/devframe#349, #355) lets buildHub bake an already-mounted context whose devframes and assets are served as root-level siblings of the hub base. Replace the hand-rolled static baker with a buildHub call, the static counterpart of the live initHub in createDevToolsHub: it reuses our kit context and emits the whole snapshot (ui slot, devframe SPAs + assets from ctx.views.buildStaticDirs, dock renderers, discovery documents, connection metas, RPC dump), so core stops shadowing and drifting from the hub pipeline. Net: buildStaticDevTools drops ~90 lines and gains a baked __index.json, per-frame __connection.json (a standalone-loaded frame now finds the shared dump), and the ui slot's setup (branding/dock preferences baked into staticConfig) for free from the shared pipeline. Deploy base and the root redirect are preserved. The build-static-renderers unit test is removed: it mocked the renderer-manifest and rpc-dump internals that now live in buildHub (covered upstream); the wiring is exercised by the cli build end to end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades devframe (and every
@devframes/*package) to^0.9.12, and retires Vite DevTools' hand-rolled static builder in favour of the hub's ownbuildHub.Background. This repo filed devframes/devframe#347 →
buildHub({ context })(devframes/devframe#349), then devframes/devframe#353 → deploy-root sibling layout (devframes/devframe#355). 0.9.12 ships both, which together letbuildHubbake an already-mounted context whose devframe SPAs and vendored assets are served as root-level siblings of the/__devtools/hub base — exactly Vite DevTools' layout.What changed.
buildStaticDevToolsnow delegates tobuildHub, the static counterpart of the liveinitHubincreateDevToolsHub. It reuses our already-assembled kit context and emits the whole snapshot itself: the brandeduislot's viewer +embedded.js, each devframe SPA and the vendored assets fromctx.views.buildStaticDirs, the dock renderers, the discovery documents, thebackend: 'static'connection metas, and the RPC dump. Core stops shadowing (and drifting from) the hub pipeline.Net −90 lines in
build-static.ts, and the snapshot gains three things the hand-rolled baker lacked, for free from the shared pipeline:__index.jsondiscovery document,__connection.json(a standalone-loaded devframe SPA now finds the shared dump),uislot'ssetupruns, baking branding / dock preferences into the connection meta'sconfigs.Deploy
base(below-root hosting) and the standalone root redirect are preserved — verified with a realcli build(default and--base /ci-build-123/): the hub subtree lands atdist/__devtools/, the devframe SPAs anddist/__devtools-assets/beside it, and the renderer imports / redirect /__index.jsonbase carry the deploy prefix.pnpm typecheck && pnpm test && pnpm lint && pnpm buildall pass.Linked Issues
Completes the
buildHubadoption tracked in devframes/devframe#347 / devframes/devframe#349 / devframes/devframe#353 / devframes/devframe#355. Supersedes #560 (the 0.9.11 bump), which can be closed in favour of this.Additional context
The
build-static-renderersunit test is removed: it mocked the renderer-manifest and RPC-dump internals that now live inbuildHub(covered by that package's own tests upstream); re-mockingbuildHub's guts would be testing implementation. The wiring is exercised by thecli buildend to end.Residual
0.9.x@devframes/*entries inpnpm-lock.yamlcome from the published@vitejs/devtools@0.5.2pulled in transitively by a fixture — pre-existing; the workspace packages all resolve to0.9.12.This PR was created with the help of an agent.