Rework `uucore::quoting_style`, add support for `locale` and `clocale` by RenjiSann · Pull Request #14856 · uutils/coreutils

RenjiSann · 2026-09-25T10:08:28Z

This PR centralizes code that was previously duplicated in several utils.

Introduce locale and clocale quoting mechanisms
Fix fmt::Display implementation for QuotingStyle, so un-parsing a QuotingStyle gives the string value it was parsed with

codspeed · 2026-09-25T11:09:53Z

Merging this PR will regress 2 benchmarks

⚡ 6 improved benchmarks
❌ 2 regressed benchmarks
✅ 389 untouched benchmarks
⏩ 54 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Simulation	`five_38_bit_primes`	1.5 s	1.8 s	-17.7%
❌	Simulation	`split_bytes`	642.4 µs	683.2 µs	-5.98%
⚡	Simulation	`three_39_bit_primes`	832.8 ms	382 ms	×2.2
⚡	Simulation	`file_localized_names`	71.1 ms	41.4 ms	+71.57%
⚡	Simulation	`split_number_chunks`	326.3 µs	276.9 µs	+17.83%
⚡	Simulation	`hostname_ip_lookup[100000]`	176.1 µs	167.5 µs	+5.13%
⚡	Simulation	`ls_recursive_deep_tree[(200, 2)]`	3.4 ms	3.3 ms	+4.53%
⚡	Simulation	`thirteen_39_bit_primes`	9.1 s	8.8 s	+3.66%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing RenjiSann:quoting-rework (5283a80) with main (01ecb91)}

54 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-09-25T12:23:19Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)

RenjiSann · 2026-09-30T09:42:03Z

Pinging you again @sylvestre so we can merge this refactor as soon as possible ^^

cakebaker · 2026-10-03T13:56:41Z

Sorry, there's a conflict :|

RenjiSann · 2026-10-04T11:40:14Z

Sorry, there's a conflict :|

Oh again :/

Splitting the `Quotes` enum allows to have a specific handling of quotes for shell and c quoting mechanisms. Especially, this prepares the terrain for locale quoting, which is just c quoting with UTF-8 quote characters.

- Replace C_NO_QUOTES with a new variant Escape - Rename QuotingStyle constants

RenjiSann · 2026-10-04T12:02:00Z

Sorry, there's a conflict :|

@cakebaker should be good !

codspeed · 2026-10-04T12:54:20Z

Unable to generate the flame graphs

The performance report has correctly been generated, but there was an internal error while generating the flame graphs for this run. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists.

…hell_escape

This was referenced Sep 25, 2026

printenv: Honor QUOTING_STYLE environment variable #14857

Open

Factorize quoting for ls, stat and make printenv honor QUOTING_STYLE #14849

Closed

RenjiSann force-pushed the quoting-rework branch 2 times, most recently from cdc1b7e to 373ee9d Compare September 25, 2026 11:09

RenjiSann force-pushed the quoting-rework branch from a1153ba to 182ed36 Compare September 25, 2026 11:35

RenjiSann requested a review from sylvestre September 25, 2026 11:41

RenjiSann mentioned this pull request Sep 25, 2026

GNU coreutils 9.12: remaining test failures - Sept 2026 #14705

Open

30 of 87 tasks

RenjiSann force-pushed the quoting-rework branch 2 times, most recently from d21d083 to 13e488b Compare September 25, 2026 13:50

sylvestre reviewed Sep 25, 2026

View reviewed changes

Comment thread src/uucore/src/lib/features/quoting_style/mod.rs Outdated

sylvestre reviewed Sep 25, 2026

View reviewed changes

Comment thread src/uucore/src/lib/features/quoting_style/mod.rs Outdated

RenjiSann force-pushed the quoting-rework branch 2 times, most recently from 8bdaa87 to b6840b9 Compare September 26, 2026 00:09