[RenjiSann]

The first part of this PR refactors quoting, especially the QUOTING_STYLE env var parsing to move it under uucore::quoting_style.

Second part implement support of QUOTING_STYLE for printenv.

[codspeed]

Merging this PR will degrade performance by 5.68%

⚡ 3 improved benchmarks
❌ 2 regressed benchmarks
✅ 384 untouched benchmarks
⏩ 54 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
❌	Simulation	three_39_bit_primes	436.5 ms	635.9 ms	-31.35%
❌	Simulation	hostname_ip_lookup[100000]	164.7 µs	176.3 µs	-6.57%
⚡	Simulation	five_38_bit_primes	2.1 s	1.9 s	+8.84%
⚡	Simulation	ls_recursive_deep_tree[(200, 2)]	3.4 ms	3.3 ms	+3.44%
⚡	Simulation	thirteen_39_bit_primes	9.3 s	9 s	+3.36%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing RenjiSann:printenv-quoting-style (511dd79) with main (3242ee4)²}

Footnotes

1. 54 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (4f7dfed) during the generation of this report, so 3242ee4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[sylvestre]

this breaks test_quoting_style_display, it still expects "C" (probably the red CI)

[RenjiSann]

Yes, I'm not sure why it was a capital C though. My understanding is that the Display trait here corresponds to the reverse operation from the "parsing", so it should be a lowercase c.

I will change the test, let's see if it breaks something on the GNU side

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)

[sylvestre]

the ci is still sad :)

[RenjiSann]

I'm having a problem with the GNU test misc/printenv.sh. Looks like it requires no quotes where I'd expect some. Also, on my machine, looks like 9.12 GNU printenv doesn't pass its own test

[RenjiSann]

This PR is getting big with the QuotingStyle refactor and the printenv support.

I'll split this work in separate PRs

[RenjiSann]

Split PRs:

• Rework uucore::quoting_style, add support for locale and clocale #14856
• printenv: Honor QUOTING_STYLE environment variable #14857