-
Notifications
You must be signed in to change notification settings - Fork 4
Replace PHPStan ignores with official phpredis stub file #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
968e8fd
Initial plan
Copilot 885b413
Add jetbrains/phpstorm-stubs and remove phpstan ignores
Copilot e0c6355
Replace jetbrains/phpstorm-stubs with custom Redis Streams stubs
Copilot 55b34a6
Use official phpredis stub file instead of custom stubs
Copilot b865335
Configure Pint to ignore stubs directory
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,8 @@ | ||
| { | ||
| "preset": "psr12", | ||
| "exclude": [ | ||
| "stubs" | ||
| ], | ||
| "rules": { | ||
| "single_quote": true | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # PHPStan Stubs | ||
|
|
||
| This directory contains stub files for PHPStan static analysis. | ||
|
|
||
| ## RedisCluster.stub.php | ||
|
|
||
| This file is the official stub file from the [phpredis](https://github.com/phpredis/phpredis) extension. | ||
|
|
||
| - **Source**: https://github.com/phpredis/phpredis/blob/develop/redis_cluster.stub.php | ||
| - **Purpose**: Provides type definitions for Redis Streams methods (xAdd, xGroup, xReadGroup, etc.) and other RedisCluster methods | ||
| - **License**: PHP License (same as phpredis extension) | ||
|
|
||
| The phpredis extension provides these stub files in their repository for static analysis tools like PHPStan. Since the stub files are not distributed with the compiled extension, we include them here for PHPStan to use during static analysis. | ||
|
|
||
| This is the recommended approach from the phpredis maintainers for using their extension with static analysis tools. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scanDirectoriesmay conflict with PHPStan's built-inRedisClusterstubsPHPStan ships with its own incomplete
RedisClusterstubs. AddingstubstoscanDirectoriestells PHPStan to discover class definitions from that directory as regular PHP code — but sinceRedisClusteris already declared in PHPStan's internal stubs, this can produce a "class already declared" error at analysis time. The correct option for overriding/extending extension stubs isstubFiles, which is specifically designed to merge with existing type definitions rather than redeclare them.