Replace PHPStan ignores with official phpredis stub file

[Copilot]

PHPStan was reporting undefined method errors for Redis Streams methods (xAdd, xGroup, xReadGroup, etc.) because the default PHP extension stubs lack these definitions. This was being suppressed with ignoreErrors.

Changes

• Added official phpredis stub file stubs/RedisCluster.stub.php from the phpredis repository with complete type definitions for Redis Streams methods and all RedisCluster methods
• Configured PHPStan to scan the local stubs directory
• Removed ignoreErrors section from phpstan.neon that was masking the undefined method warnings
• Added documentation in stubs/README.md explaining the source and purpose of the stub file
• Configured Pint to exclude the stubs directory from code style checks

This ensures proper static analysis for Redis Streams operations without suppressing legitimate type checking, and without requiring external dependencies. The stub file is maintained by the phpredis extension authors and is the recommended approach for using phpredis with static analysis tools.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/JetBrains/phpstorm-stubs/contents/redis/RedisCluster.php
  • Triggering command: /usr/bin/curl curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[abnegate]

Added jetbrains/phpstorm-stubs as dev dependency - provides complete type definitions for Redis Streams methods on RedisCluster

@copilot do this without a dependency

[Copilot]

Added jetbrains/phpstorm-stubs as dev dependency - provides complete type definitions for Redis Streams methods on RedisCluster

@copilot do this without a dependency

Created a custom stub file stubs/RedisCluster.stub.php with type definitions for all Redis Streams methods used in the codebase. Removed the jetbrains/phpstorm-stubs dependency and configured PHPStan to scan the local stubs directory instead. (commit e0c6355)

[abnegate]

Added jetbrains/phpstorm-stubs as dev dependency - provides complete type definitions for Redis Streams methods on RedisCluster

@copilot do this without a dependency

Created a custom stub file stubs/RedisCluster.stub.php with type definitions for all Redis Streams methods used in the codebase. Removed the jetbrains/phpstorm-stubs dependency and configured PHPStan to scan the local stubs directory instead. (commit e0c6355)

@copilot Can't they come from the redis extension itself or something without hacks?

[Copilot]

Added jetbrains/phpstorm-stubs as dev dependency - provides complete type definitions for Redis Streams methods on RedisCluster

...

Yes! The phpredis extension provides official stub files in their repository for static analysis. I've replaced the custom stub with the official redis_cluster.stub.php from the phpredis project (https://github.com/phpredis/phpredis/blob/develop/redis_cluster.stub.php). This is the recommended approach for using phpredis with PHPStan - the stub files are maintained by the extension authors but aren't distributed with the compiled extension, so we include them locally for static analysis. (commit 55b34a6)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/phpredis/phpredis/contents
  • Triggering command: /usr/bin/curl curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[abnegate]

@copilot Make pint ignore the phpredis stubs

[Copilot]

@copilot Make pint ignore the phpredis stubs

Added "exclude": ["stubs"] to pint.json to prevent Pint from linting the phpredis stub files. (commit b865335)

[greptile-apps]

Greptile Summary

This PR replaces PHPStan ignoreErrors suppressions with a bundled RedisCluster stub file to properly expose Redis Streams method types. Two issues need attention before merging:

• Wrong PHPStan config key: scanDirectories discovers symbols from regular PHP code but does not override PHPStan's built-in extension stubs — using it for a RedisCluster redeclaration is likely to produce a "class already declared" conflict. The stubFiles key is the correct option for supplementing extension stubs.
• UNKNOWN placeholder constants: The stub is phpredis's C extension build-system file where UNKNOWN is substituted by the C compiler. As plain PHP, UNKNOWN is an undefined constant; PHPStan will either error on it or infer the wrong type (string instead of int) for all five RedisCluster failover constants.

Confidence Score: 3/5

Two P1 issues may make the PHPStan configuration produce new errors rather than fix existing ones; not safe to merge as-is.

Two P1 findings: wrong PHPStan config key (scanDirectories vs stubFiles) that can cause class-redefinition errors, and five UNKNOWN constant references in the stub that are undefined in PHP. Either issue alone could leave PHPStan in a worse state than before the PR.

phpstan.neon (wrong config key) and stubs/RedisCluster.stub.php (UNKNOWN constants)

Important Files Changed

Filename	Overview
phpstan.neon	Removes ignoreErrors suppression and adds stubs to scanDirectories, but stubFiles is the correct PHPStan option for stub overrides and avoids class redefinition conflicts.
stubs/RedisCluster.stub.php	C extension build-system stub copied from phpredis source; five class constants use UNKNOWN (an undefined PHP constant) as their value, which will cause PHPStan/PHP parser issues.
pint.json	Excludes the new stubs directory from Pint code-style checks — appropriate and correct.
stubs/README.md	New documentation file describing the stub's source and purpose; accurate and well-written.

_{Reviews (1): Last reviewed commit: "Configure Pint to ignore stubs directory" | Re-trigger Greptile}

[greptile-apps]

scanDirectories may conflict with PHPStan's built-in RedisCluster stubs

PHPStan ships with its own incomplete RedisCluster stubs. Adding stubs to scanDirectories tells PHPStan to discover class definitions from that directory as regular PHP code — but since RedisCluster is already declared in PHPStan's internal stubs, this can produce a "class already declared" error at analysis time. The correct option for overriding/extending extension stubs is stubFiles, which is specifically designed to merge with existing type definitions rather than redeclare them.

Suggested change

	scanDirectories:
	- vendor/swoole
	# phpredis stubs don't include Redis Streams methods (xAdd, xGroup, etc.)
	# These methods exist at runtime but PHPStan's stubs are incomplete
	# See: https://github.com/phpredis/phpredis-stubs/issues
	ignoreErrors:
	-
	message: '#Call to an undefined method RedisCluster::(x(Add|Group|ReadGroup|Ack|Pending|Claim|AutoClaim|Del|Len|Trim|Info|Range|RevRange)|eval)\(\)#'
	path: src/Queue/Connection/RedisStreamCluster.php
	\ No newline at end of file
	- stubs
	scanDirectories:
	- vendor/swoole
	stubFiles:
	- stubs/RedisCluster.stub.php

[greptile-apps]

UNKNOWN is an undefined constant that will trigger PHPStan errors

This file is the phpredis C extension build-system stub (redis_cluster.stub.php), not a PHPStan stub. The UNKNOWN placeholder (also annotated with @cvalue) is replaced by the actual integer value during C compilation — it does not exist as a PHP symbol. All five class constants use it:

public const OPT_SLAVE_FAILOVER         = UNKNOWN;
public const FAILOVER_NONE              = UNKNOWN;
public const FAILOVER_ERROR             = UNKNOWN;
public const FAILOVER_DISTRIBUTE        = UNKNOWN;
public const FAILOVER_DISTRIBUTE_SLAVES = UNKNOWN;

When PHPStan encounters = UNKNOWN, it resolves it as an undefined constant and will either raise an error or silently fall back to the string "UNKNOWN", neither of which is the intended int type. Replace UNKNOWN with a concrete integer sentinel (e.g., 0) so the constants carry a valid type for static analysis purposes.