Skip to content

Preserve net-owned obstacle regions #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0hmX merged 1 commit into from
Jul 17, 2026
Merged

Preserve net-owned obstacle regions #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/compat/loadSerializedHyperGraph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ const isFullObstacleRegion = (
return false
}

if (region.d?._containsTarget !== true) {

@0hmX 0hmX Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was removing obstacle regions that did not contain a connection endpoint.

But due to component topology generation with rectangles, some obstacle regions do not contain an endpoint but are still assigned to a net. Those net-owned regions must be preserved, because they can contain valid routing ports and edges.

return true
}

const netId = getSerializedRegionNetId(region)
return netId === undefined || netId === -1
}
Expand Down
Loading