Skip to content

Preserve net-owned obstacle regions#131

Merged
0hmX merged 1 commit into
mainfrom
fix/preserve-net-owned-obstacle-regions
Jul 17, 2026
Merged

Preserve net-owned obstacle regions#131
0hmX merged 1 commit into
mainfrom
fix/preserve-net-owned-obstacle-regions

Conversation

@0hmX

@0hmX 0hmX commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@tscircuitbot

Copy link
Copy Markdown

Benchmark This PR

Run benchmarks by commenting on this PR:

/benchmark [benchmark.sh args...]
/benchmark --dataset <hg07|srj18> --limit <n> --solver <core|poly> --families <default|default+deep|all> --concurrency <n|auto>

Everything after /benchmark is forwarded directly to ./benchmark.sh.
The result comment shows the matching dataset from the latest stored main-branch benchmark artifact beside the PR run; main is not rerun for each PR benchmark request.

Examples:

  • /benchmark -> hg07, all samples, core solver
  • /benchmark --dataset srj18 --limit 20 -> first 20 srj18 samples
  • /benchmark --dataset srj18 --concurrency auto -> srj18 samples with runner CPU-count concurrency
  • /benchmark --sample sample002 -> one hg07 sample
  • /benchmark --limit 20 --solver poly -> first 20 hg07 samples with the poly solver
  • /benchmark --limit 40 --families default+deep -> first 40 hg07 samples with deeper candidate families

Any PR whose title contains [BENCHMARK TEST] will automatically run the benchmark workflow on PR updates.

@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tiny-hypergraph Ready Ready Preview, Comment Jul 17, 2026 6:08am

Request Review

return false
}

if (region.d?._containsTarget !== true) {

@0hmX 0hmX Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was removing obstacle regions that did not contain a connection endpoint.

But due to component topology generation with rectangles, some obstacle regions do not contain an endpoint but are still assigned to a net. Those net-owned regions must be preserved, because they can contain valid routing ports and edges.

@0hmX
0hmX merged commit b0a8272 into main Jul 17, 2026
7 checks passed
@tscircuitbot

Copy link
Copy Markdown

Thank you for your contribution! 🎉

PR Rating: ⭐⭐⭐
Impact: Major

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants