Skip to content

[codex] Remove empty section optimize skip #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0hmX wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[codex] Remove empty section optimize skip #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 0 additions & 51 deletions lib/section-solver/TinyHyperGraphSectionPipelineSolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,14 +382,6 @@ export class TinyHyperGraphSectionPipelineSolver extends BasePipelineSolver<Tiny
}
}

override _step() {
if (this.trySkipEmptyOptimizeSection()) {
return
}

super._step()
}

override pipelineDef: PipelineStep<any>[] = [
{
solverName: "solveGraph",
Expand Down Expand Up @@ -527,49 +519,6 @@ export class TinyHyperGraphSectionPipelineSolver extends BasePipelineSolver<Tiny

return this.cachedSectionStageParams
}

private trySkipEmptyOptimizeSection() {
if (
this.getCurrentStageName() !== "optimizeSection" ||
this.activeSubSolver
) {
return false
}

const solveGraphOutput =
this.getStageOutput<SerializedHyperGraph>("solveGraph")

if (!solveGraphOutput) {
return false
}

const [, problem] = this.getSectionStageParams()
let sectionMaskPortCount = 0
for (const value of problem.portSectionMask) {
if (value === 1) {
sectionMaskPortCount += 1
}
}

if (sectionMaskPortCount !== 0) {
return false
}

this.pipelineOutputs.optimizeSection = solveGraphOutput
this.stats = {
...this.stats,
activeRouteCount: 0,
optimized: false,
sectionOptimizationSkipped: true,
sectionOptimizationReason: "empty-section-mask",
}
this.currentPipelineStageIndex++
// The section stage will never run, so the topology/problem/solution view
// loaded for the mask check is dead weight from here on.
this.cachedSectionStageParams = undefined
return true
}

getInitialVisualizationSolver() {
if (!this.initialVisualizationSolver) {
const { topology, problem } = this.loadHyperGraph(
Expand Down
Loading