[codex] Remove empty section optimize skip#117
Open
0hmX wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This removes the empty-section fast path added in
7891dd9fromTinyHyperGraphSectionPipelineSolver.Specifically, it removes:
_step()override that short-circuitsoptimizeSectiontrySkipEmptyOptimizeSection()The rest of the
7891dd9memory optimization set is left intact.Why
7891dd9introduced a real port-point-pathing memory improvement, but it also changed downstream routing output intscircuit-autorouterand caused SVG snapshot regressions.The highest-signal behavior change was the new empty-section skip. In pipeline4 consumers, an empty section mask is exercised, and skipping
optimizeSectionentirely changes the final route geometry.This PR keeps the memory optimization work while removing the output-changing fast path.
Impact
7891dd9Validation
Downstream SVG / snapshot checks in
tscircuit-autorouterpassed with this skip-only variant:bun test tests/e2e3.test.tsbun test tests/e2e3-multisection.test.tsbun test tests/features/pipeline4-dataset01-circuit011-visual.test.tsbun test tests/features/pipeline4-dataset01-circuit015-visual.test.tsPort-point-pathing memory comparison on
srj18 sample001using/usr/bin/timepeak RSS:origin/main
full 7891dd9
skip-only variant
So this variant remains about 34% below the
origin/mainbaseline while staying within about 5.5 MB average RSS of full7891dd9.