Skip to content

Replace removed localstack 0.12.8 test image with 0.13.0 - #12163

Merged
kiview merged 1 commit into
mainfrom
claude/project-thread-5tp55x
Nov 14, 2026
Merged

kiview merged 1 commit into
mainfrom
claude/project-thread-5tp55x

Conversation

@kiview

@kiview kiview commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Docker Hub no longer serves any localstack/localstack 0.12.x tag (0.12, 0.12.0 to 0.12.20 all return 404). Because of that, LegacyModeTest fails on every full CI run on main with manifest for localstack/localstack:0.12.8 not found.

This PR is a targeted fix. It replaces the 0.12.8 test image with 0.13.0, the closest version that is still published. The image is used in two places:

  • the non-legacy default case (labelled "0.13" now)
  • the base image that gets retagged as custom for the legacy-mode case

The constant is renamed LOCALSTACK_0_12_IMAGE → LOCALSTACK_0_13_IMAGE so it matches the tag. Nothing else changes. The 0.10.7 and 0.11.3 images used by the other cases still exist.

Main CI history: the localstack job passed on every run from April to 25 October. The only failures are this 404, so no retry or wait-strategy change is needed.


Generated by Claude Code

Summary by CodeRabbit

  • Tests
    • Updated LocalStack legacy-mode test scenarios to use version 0.13.0 instead of 0.12.8.
    • The test suite now checks legacy-mode behavior against the newer LocalStack image. This change affects test coverage only; it does not change application behavior.

Docker Hub no longer serves any localstack/localstack 0.12.x tag, so
LegacyModeTest fails with a 404 when pulling 0.12.8. Use 0.13.0, the
closest version still published, for the non-legacy default case and as
the base for the custom-tag legacy case.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015e4ZbVeaqHdbxXHBUWarxn
@kiview
kiview requested a review from a team as a code owner November 14, 2026 11:18
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The LocalStack test image constant changes from version 0.12.8 to 0.13.0. Legacy-mode tests use LocalStack 0.13 for the custom image and legacy-off cases.

Changes: LocalStack test image update

Layer / File(s) Summary
Update legacy-mode test image
modules/localstack/src/test/java/org/testcontainers/containers/localstack/LocalstackTestImages.java, modules/localstack/src/test/java/org/testcontainers/containers/localstack/LegacyModeTest.java
The test image constant changes to LOCALSTACK_0_13_IMAGE with tag 0.13.0. The custom image and legacy-off test cases now use LocalStack 0.13.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: eddumelendez, rnorth

Merge Risk: Minimal · up to 54d33

This updates the LocalStack image used in legacy-mode tests because the 0.12.x tags are no longer served. It affects tests only, with no production impact, and carries minimal merge risk.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the LocalStack 0.12.8 test image used by LegacyModeTest is replaced with 0.13.0. The raw summary confirms this change in LegacyModeTest and LocalstackTestImages, with …
Description check Passed The description covers the required parts of the template: the reason for the change (Docker Hub 404 for 0.12.x tags), what changed (image swap, constant rename, affected usages), and a note that no r…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the LocalStack 0.12.8 test image used by LegacyModeTest is replaced with 0.13.0. The raw summary confirms this change in LegacyModeTest and LocalstackTestImages, with the constant renamed from LOCALSTACK_0_12_IMAGE to LOCALSTACK_0_13_IMAGE.

Full details: Description check

Explanation

The description covers the required parts of the template: the reason for the change (Docker Hub 404 for 0.12.x tags), what changed (image swap, constant rename, affected usages), and a note that no retry or wait-strategy change is needed. The template's general guidance is followed. It does not reference an issue, which the template only asks for when one exists, and the change is not a new module or a bare dependency bump.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c02f1b12-498f-4223-a73d-3d9c7e48549b
Commits

Reviewing files that changed from the base of the PR and between beb8f38 and 54d3319.

Files selected for processing: 2

  • modules/localstack/src/test/java/org/testcontainers/containers/localstack/LegacyModeTest.java
  • modules/localstack/src/test/java/org/testcontainers/containers/localstack/LocalstackTestImages.java

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

kiview commented Nov 14, 2026

Copy link
Copy Markdown
Member Author

The check_examples (:sftp:check) failure is unrelated to this PR, but it's the same kind of problem. examples/sftp pins atmoz/sftp:alpine-3.7, and that tag has also been removed from Docker Hub (404 on pull). The repo now only publishes alpine, debian and latest. This PR doesn't touch examples/sftp, so I'm leaving it out of scope here.


Generated by Claude Code

@kiview
kiview merged commit 6d1eeec into main Nov 14, 2026
97 of 98 checks passed
@kiview
kiview deleted the claude/project-thread-5tp55x branch November 14, 2026 15:41
@kiview kiview added this to the next milestone Nov 14, 2026 — with Claude
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants