Skip to content

Pin removed atmoz/sftp:alpine-3.7 example image to alpine digest - #12165

Open
kiview wants to merge 3 commits into
mainfrom
claude/project-thread-5tp55x-sftp
Open

kiview wants to merge 3 commits into
mainfrom
claude/project-thread-5tp55x-sftp

Conversation

@kiview

@kiview kiview commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Docker Hub no longer serves atmoz/sftp:alpine-3.7. The repo now only publishes alpine, debian and latest. Because of that, check_examples (:sftp:check) fails with manifest for atmoz/sftp:alpine-3.7 not found (seen on #12163).

This PR pins both tests in examples/sftp to the current alpine tag by digest (atmoz/sftp:alpine@sha256:c5fb9e4b…, published 2026-11-06), so the example stays reproducible even though upstream has no versioned tags anymore. Nothing else changes.

This is separate from the LocalStack image fix in #12163, which has the same root cause (an upstream deleted an old tag).


Generated by Claude Code

Summary by CodeRabbit

  • Tests
    • SFTP tests now use a specific, fixed version of the test image instead of a floating Alpine-based tag. Test setup and assertions remain unchanged, so the tests continue to check the same behavior. This update affects only the test environment and does not change application functionality or behavior for users.

Docker Hub no longer serves atmoz/sftp:alpine-3.7 (only alpine, debian
and latest remain), so the sftp example tests fail with a 404 on pull.
Pin the current alpine tag by digest to keep the example reproducible.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015e4ZbVeaqHdbxXHBUWarxn
@kiview
kiview requested a review from a team as a code owner November 14, 2026 11:53
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Both SFTP tests now use the atmoz/sftp:alpine image pinned to a SHA-256 digest instead of the alpine-3.7 tag. The test setup and assertions are unchanged.

Changes: SFTP Test Image Pinning

Layer / File(s) Summary
Pin SFTP test images
examples/sftp/src/test/java/org/example/SftpContainerTest.java
The test and testHostKeyCheck methods use the digest-pinned atmoz/sftp:alpine image. Their test logic is unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: eddumelendez, julianladisch

Merge Risk: Minimal · up to 656a2

This is a test-only change to the SFTP example's container image reference. It does not affect production behavior, and no merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the removed atmoz/sftp:alpine-3.7 example image is pinned to an alpine digest. The raw summary confirms both SFTP tests now use the digest-pinned alpine image. The tit…
Description check Passed The description states the problem: Docker Hub no longer serves atmoz/sftp:alpine-3.7, and the check_examples (:sftp:check) job fails with a manifest-not-found error. It states the fix: both tests in …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the removed atmoz/sftp:alpine-3.7 example image is pinned to an alpine digest. The raw summary confirms both SFTP tests now use the digest-pinned alpine image. The title's wording is slightly awkward ("Pin removed ... image to alpine digest"), but it stays on topic and specific.

Full details: Description check

Explanation

The description states the problem: Docker Hub no longer serves atmoz/sftp:alpine-3.7, and the check_examples (:sftp:check) job fails with a manifest-not-found error. It states the fix: both tests in examples/sftp pin to atmoz/sftp:alpine by SHA-256 digest. It also states that nothing else changes and links the related LocalStack issue. The template asks for a brief description of the changes and their context, and this text covers both. The template's notes on new modules and dependency upgrades do not apply to this change, so their absence is not a gap.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b06a97f6-55b7-44b0-be0a-5221f5ea2e5c
Commits

Reviewing files that changed from the base of the PR and between f06e728 and 656a2bf.

Files selected for processing: 1

  • examples/sftp/src/test/java/org/example/SftpContainerTest.java
Files skipped from review as they are similar to previous changes: 1

  • examples/sftp/src/test/java/org/example/SftpContainerTest.java

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

kiview commented Nov 14, 2026

Copy link
Copy Markdown
Member Author

The check (:testcontainers-localstack:check) failure here is unrelated to this PR. LegacyModeTest gets a 404 on localstack/localstack:0.12.8, which was removed from Docker Hub, and it fails the same way on main. #12163 fixes it. This PR only touches examples/sftp.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants