-
Notifications
You must be signed in to change notification settings - Fork 4
chore: align pr templates #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,29 @@ | ||
| <!-- Closes | Fixes | Resolves #ISSUE_ID --> | ||
| <!-- Changelog: For user-facing changes, add one fragment in changelog.d/next/ or changelog.d/hotfix/. Do not edit CHANGELOG.md in normal PRs. --> | ||
| <!-- Brief summary of the PR changes, linking to the related resources (issue/design/bug/etc) if applicable. --> | ||
|
|
||
| ### Description | ||
|
|
||
| Please include a summary of changes and which issues are fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. | ||
| <!-- One bullet per change: what changed and why. --> | ||
|
|
||
| ### Linked Issues/Tasks | ||
| #### Out of Scope | ||
|
|
||
| Add any links to GitHub issues or Asana tasks that are relevant to this pull request. | ||
| <!-- One bullet per item this PR deliberately leaves out (`path/or/area: item`); reviewers treat them as your non-goals. `None.` when nothing is left out. Required for feat, fix, and refactor PRs; delete it for version, changelog, or dependency bumps and release PRs; other chore, docs, and test PRs at your discretion. --> | ||
|
|
||
| ### Design | ||
|
|
||
| <!-- | ||
| - Existing UI design: link the relevant Figma frames, starting with the latest `Bitkit - Handoff vNN` page in https://www.figma.com/design/ltqvnKiejWj0JQiqtDf2JJ/. | ||
| - No available design, including new features: `N/A — no design available.` | ||
| - No user-visible UI changes: `N/A — no UI changes.` | ||
| - Missing or uncertain Figma frame: state the uncertainty. | ||
| - Never invent a Figma link or require a new design. | ||
| --> | ||
| <!-- Figma frames for the changed UI (latest `Bitkit - Handoff vNN` page in https://www.figma.com/design/ltqvnKiejWj0JQiqtDf2JJ/). Otherwise `N/A — no UI changes.` or `N/A — no design available.` State an uncertain match; never invent a link. --> | ||
|
|
||
| ### Screenshot / Video | ||
| ### Preview | ||
|
|
||
| Insert relevant screenshot / recording | ||
| <!-- Screenshot or recording of the changed UI; `N/A` when there is no user-visible change. --> | ||
|
|
||
| ### QA Notes | ||
|
|
||
| #### Manual Tests | ||
|
|
||
| <!-- Unchecked, numbered steps for the reviewer: action → expectation. `N/A` when there is nothing to verify by hand. --> | ||
|
|
||
| #### Automated Checks | ||
|
|
||
| <!-- Coverage added, changed, or removed, by test file name; non-standard commands you ran. `N/A` when nothing changed. --> | ||
|
ovitrif marked this conversation as resolved.
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.