Conversation
|
569a41d to
3ff5fad
Compare
|
@greptileai review |
785b3c4 to
8e224a5
Compare
8e224a5 to
eadec51
Compare
|
one review is enough, I added everyone for signing off / mainly covered by simply checking the PR description, feedback welcome. |
jvsena42
left a comment
There was a problem hiding this comment.
Reviewed as a docs change, so the question is who acts on this and what do they get wrong — these files are executed by coding agents, not just read by humans. No blockers. Two LOW divergences inline, both in the direction of "the alignment pass missed a spot".
Neither is about wording. Both are places where an agent following the text literally produces a different result on iOS than on Android, which is the one thing a PR titled "align pr templates" should not leave behind.
The templates themselves are aligned. A mechanical diff of the two final pull_request_template.md files is one line — line 15, where Android points at docs/screens-map.md and iOS points at the Figma handoff URL. That is a legitimate per-repo difference: the screens map exists only in Android (git ls-tree on both heads), and the iOS URL matches AGENTS.md:342. The Description Rules and Out of Scope blocks in pr.md are byte-identical across the two repos.
Nothing required was dropped. I accounted for all 13 removed lines:
| Removed | Verdict |
|---|---|
| "summary of changes and which issues are fixed" | survives at :7; issue linking moves to :1 closing keywords and pr.md:68-73 |
| "List any dependencies that are required for this change" | genuinely dropped — git grep -i "list any dependencies" finds nothing at head. Android never had it, so this is alignment, not loss |
### Linked Issues/Tasks |
replaced by the :1 <!-- Closes | Fixes | Resolves #ISSUE_ID --> comment |
| "GitHub issues or Asana tasks" | GitHub part survives; Asana genuinely dropped — git grep -i asana returns nothing in either repo at head |
6-line ### Design comment block |
condensed into :15; the full contract survives in pr.md:121-130 and AGENTS.md:342-348 |
### Screenshot / Video |
renamed to ### Preview, and release.md:133 was updated in the same commit. git grep -i "Screenshot / Video" across the whole head returns nothing, so no dangling reference |
| "Insert relevant screenshot / recording" | survives at :19, now with an N/A rule |
Also checked: every path the new text references exists at head; no placeholder an agent would copy literally into a real PR (all new guidance sits inside HTML comments, and each live heading carries a fill-or-delete rule); .github/copilot-instructions.md carries no PR-description guidance, so nothing there conflicts.
The Android twin (synonymdev/bitkit-android#1262) came back clean — no findings — so these two are the only gaps between the pair.
Closes #749
This PR gives the PR template one shape shared with bitkit-android: scope stated in the description, one line of design guidance, a
### Previewsection, and QA Notes with its subsections.Description
#### Out of Scopesubsection at the end of### Descriptionso reviewers read the author's non-goals instead of guessing them.feat,fix, andrefactorPRs; version bumps, changelog, and release PRs skip it, and other chores include it at the author's discretion.### Description, what changed and why, so the intent of each change is on record.### Linked Issues/Taskswith theCloses #comment at the top and turns placeholder text into comments so unfilled guidance does not land in PR bodies.### Designguidance to one line; the full rules stay in the/prcommand.### Screenshot / Videoto### Preview, the heading the/prcommand and the review tooling already key on, in the template and the release command body.### QA Noteswith#### Manual Testsand#### Automated Checks, the structure the/prcommand already generates./prcommand the scope rules so agent-authored PRs follow them.Out of Scope
.agents/commands/release.md: version-bump PRs keep their fixed body without the scope subsection; only the Preview heading was renamed.Design
N/A — no UI changes.
Preview
N/A
QA Notes
Manual Tests
#### Out of Scopeat the end of### Description, a one-line### Designcomment,### Preview, and### QA Noteswith#### Manual Testsand#### Automated Checks; noLinked Issues/Taskssection remains.Automated Checks
N/A — template and command text only.