Skip to content

ci(repo): stop the flaky check failing on the removed cli-go package #7421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7ttp merged 2 commits into from
Oct 30, 2026
+2 −13
Merged

ci(repo): stop the flaky check failing on the removed cli-go package #7421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b966935
ci(repo): stop the flaky check failing on the removed cli-go package
7ttp Oct 30, 2026
dc6415f
nit
7ttp Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/scripts/flaky-check/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,6 @@ async function runCommand(): Promise<number> {
entry.suite === "focused" && filters.length === 0
? ["--changed", capture(["git", "merge-base", "HEAD", `origin/${env("BASE_REF")}`])]
: filters;
if (entry.suite === "e2e") {
process.env.SUPABASE_GO_BINARY = join(process.cwd(), "apps/cli-go/supabase-go");
}
if (entry.suite === "e2e" && entry.target === "cli") {
// Matches test.yml, so concurrency-sensitive flakes show up here too.
process.env.SUPABASE_E2E_WORKERS = "4";
Expand Down
5 changes: 1 addition & 4 deletions .github/scripts/flaky-check/plan.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,7 @@ describe("commandsFor", () => {
const invocations = commandsFor(entry("flaky-focused-run1"), 3, ["--changed", "abc123"]);

expect(invocations.map((i) => [i.reports, outputOf(i.argv)])).toEqual([
[
{ turbo: ["test:unit:run", "--filter=!@supabase/cli-go"], report: "unit.3" },
".flaky-results/unit.3.json",
],
[{ turbo: ["test:unit:run"], report: "unit.3" }, ".flaky-results/unit.3.json"],
[
{ turbo: ["test:integration:run", "--filter=!@supabase/api"], report: "integration.3" },
".flaky-results/integration.3.json",
Expand Down
7 changes: 1 addition & 6 deletions .github/scripts/flaky-check/plan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,12 +218,7 @@ function api(runtime: string[], project: string, report: string, extra: string[]
}

function unit(iteration: number, extra: string[]): Invocation[] {
return [
turbo(["test:unit:run", "--filter=!@supabase/cli-go"], `unit.${iteration}`, [
"--passWithNoTests",
...extra,
]),
];
return [turbo(["test:unit:run"], `unit.${iteration}`, ["--passWithNoTests", ...extra])];
}

// @supabase/api chains a Node and a Bun Vitest run in one script, and Turbo forwards arguments
Expand Down
Loading