Skip to content

ci(repo): stop the flaky check failing on the removed cli-go package - #7421

Merged
7ttp merged 2 commits into
developfrom
7ttp/red-flaky-check
Oct 30, 2026
Merged

7ttp merged 2 commits into
developfrom
7ttp/red-flaky-check

Conversation

@7ttp

@7ttp 7ttp commented Oct 30, 2026

Copy link
Copy Markdown
Member

TL;DR

stops the unit and focused flaky checks failing before any test runs, by dropping the filter on the removed cli-go package

ref

@7ttp 7ttp added the run-flaky-check Run the flaky-test check on this PR label Oct 30, 2026
@7ttp
7ttp requested a review from a team as a code owner October 30, 2026 14:01
@github-actions github-actions Bot removed the run-flaky-check Run the flaky-test check on this PR label Oct 30, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews were available. The changed unit invocation and test expectation agree; no regression was identified. Claude's stale environment-variable finding is confirmed as a harmless, pre-existing cleanup nit outside the diff.

Findings

Severity Location Category Sources Claim
⚪ NIT .github/scripts/flaky-check/cli.ts:115 dead-code claude The flaky-check runner still sets the unused SUPABASE_GO_BINARY variable to the removed apps/cli-go/supabase-go path for e2e suites.

Findings outside the diff

  • ⚪ NIT .github/scripts/flaky-check/cli.ts:115 — The flaky-check runner still sets the unused SUPABASE_GO_BINARY variable to the removed apps/cli-go/supabase-go path for e2e suites.

Stats

Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@github-actions

Copy link
Copy Markdown
Contributor

Flaky test check: ✅ no flaky tests

Commit 09960d4f4459 · focused ×10 (no tests ran) · integration ×10, 6664 tests · unit ×10, 9267 tests · workflow run

Each execution is a separate Vitest process; Where lists failing runs, as run.iteration for suites executed more than once per run. The full data is in the flaky-check-report artifact.

@7ttp 7ttp self-assigned this Oct 30, 2026
@7ttp
7ttp added this pull request to the merge queue Oct 30, 2026
Merged via the queue into develop with commit daddfbc Oct 30, 2026
46 checks passed
@7ttp
7ttp deleted the 7ttp/red-flaky-check branch October 30, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants