Repository navigation
ci(repo): stop the flaky check failing on the removed cli-go package - #7421
Conversation
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews were available. The changed unit invocation and test expectation agree; no regression was identified. Claude's stale environment-variable finding is confirmed as a harmless, pre-existing cleanup nit outside the diff.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | .github/scripts/flaky-check/cli.ts:115 |
dead-code |
claude | The flaky-check runner still sets the unused SUPABASE_GO_BINARY variable to the removed apps/cli-go/supabase-go path for e2e suites. |
Findings outside the diff
- ⚪ NIT
.github/scripts/flaky-check/cli.ts:115— The flaky-check runner still sets the unused SUPABASE_GO_BINARY variable to the removed apps/cli-go/supabase-go path for e2e suites.
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Flaky test check: ✅ no flaky testsCommit Each execution is a separate Vitest process; |
TL;DR
stops the
unitandfocusedflaky checks failing before any test runs, by dropping the filter on the removedcli-gopackageref