Skip to content

test(cli): cover the remaining test files with effect lint (CLI-2898) - #7414

Merged
7ttp merged 3 commits into
developfrom
7ttp/cli-2898-effect-lint-exclusions
Oct 30, 2026
Merged

7ttp merged 3 commits into
developfrom
7ttp/cli-2898-effect-lint-exclusions

Conversation

@7ttp

@7ttp 7ttp commented Oct 30, 2026

Copy link
Copy Markdown
Member

TL;DR

brings the last excluded test files under the effect lint

whats introduced?

  • the seven test files from the --remote and config values work and the local-db-running integration test drop their node: imports and process.env writes for FileSystem, Path, Config and vi.stubEnv
  • the target selection and hosted consent helpers type their error channels as Error instead of unknown
  • goldenJson becomes an effect, so its four callers yield it
  • the same tests run with the same results

ref

@7ttp 7ttp self-assigned this Oct 30, 2026
@7ttp
7ttp added this pull request to stack #7386 October 30, 2026 12:12
@7ttp
7ttp requested a review from a team as a code owner October 30, 2026 12:12
@github-actions

Copy link
Copy Markdown
Contributor

CLI benchmark: no changes found

Commit f976679 against 7ttp/cli-2880-replay-server-coverage at 7a3ea87 · 10 runs each · report only, never blocks merging

Command Before After Change
supabase --version 204 ms 210 ms no real change
supabase --help 218 ms 215 ms no real change
supabase init 232 ms 220 ms no real change (-5%, within normal variation)
supabase migration new bench 235 ms 231 ms no real change
supabase gen types --lang typescript --project-id replayfixtureprojref 263 ms 268 ms no real change
supabase projects list 251 ms 259 ms no real change
supabase functions list --project-ref replayfixtureprojref 282 ms 286 ms no real change

API calls: unchanged for all 7 commands.

Binary size: 134.0 MB, unchanged.

Details: timing ranges, API calls per command, slowest phases

Timing ranges

Command Before range After range Change Verdict
supabase --version 194-231 ms 196-223 ms +6 ms (+3%) within noise
supabase --help 193-249 ms 184-245 ms -4 ms (-2%) within noise
supabase init 215-272 ms 206-252 ms -12 ms (-5%) within noise
supabase migration new bench 213-280 ms 202-276 ms -4 ms (-2%) within noise
supabase gen types --lang typescript --project-id replayfixtureprojref 241-307 ms 231-303 ms +6 ms (+2%) within noise
supabase projects list 236-293 ms 225-279 ms +8 ms (+3%) within noise
supabase functions list --project-ref replayfixtureprojref 238-449 ms 230-358 ms +3 ms (+1%) within noise

API calls per command

Command Before After Endpoint changes
supabase --version 0 0
supabase --help 0 0
supabase init 0 0
supabase migration new bench 0 0
supabase gen types --lang typescript --project-id replayfixtureprojref 2 2
supabase projects list 1 1
supabase functions list --project-ref replayfixtureprojref 2 2

Slowest phases

No command moved beyond noise, so there are no phase deltas.

Comment /bench to run it again on the latest commit.

Workflow run

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Confirmed one pre-existing, non-blocking test-cleanup nit from Claude. Codex reported no findings, and no additional defects were found. Tests were not run because dependencies are unavailable.

Findings

Severity Location Category Sources Claim
⚪ NIT apps/cli/src/command-internal/config-validate.parity.unit.test.ts:36 test-hygiene claude The temporary config directory leaks when setup or an assertion fails because its cleanup is not registered with a scope or finalizer. This behavior predates the PR.

Stats

Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

Comment thread apps/cli/src/command-internal/config-validate.parity.unit.test.ts Outdated
@7ttp 7ttp added the run-flaky-check Run the flaky-test check on this PR label Oct 30, 2026
@github-actions github-actions Bot removed the run-flaky-check Run the flaky-test check on this PR label Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Flaky test check: ✅ no flaky tests

Commit b56c8f83aa1d · focused ×10 (5 executions each), 3589 tests · integration ×10, 6664 tests · unit ×10, 9267 tests · workflow run

Each execution is a separate Vitest process; Where lists failing runs, as run.iteration for suites executed more than once per run. The full data is in the flaky-check-report artifact.

Base automatically changed from 7ttp/cli-2880-replay-server-coverage to develop October 30, 2026 13:07
@7ttp
7ttp requested a review from supabase-oss as a code owner October 30, 2026 13:07
@7ttp 7ttp added the run-flaky-check Run the flaky-test check on this PR label Oct 30, 2026
@github-actions github-actions Bot removed the run-flaky-check Run the flaky-test check on this PR label Oct 30, 2026
@7ttp 7ttp added the run-flaky-check Run the flaky-test check on this PR label Oct 30, 2026
@github-actions github-actions Bot removed the run-flaky-check Run the flaky-test check on this PR label Oct 30, 2026

@Coly010 Coly010 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Comment thread apps/cli/src/command-internal/config-validate.parity.unit.test.ts Outdated
@7ttp
7ttp added this pull request to the merge queue Oct 30, 2026
Merged via the queue into develop with commit e713e69 Oct 30, 2026
49 checks passed
@7ttp
7ttp deleted the 7ttp/cli-2898-effect-lint-exclusions branch October 30, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants