Repository navigation
test(cli): cover the remaining test files with effect lint (CLI-2898) - #7414
Conversation
CLI benchmark: no changes foundCommit
API calls: unchanged for all 7 commands. Binary size: 134.0 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
There was a problem hiding this comment.
🤖 AI Review
Confirmed one pre-existing, non-blocking test-cleanup nit from Claude. Codex reported no findings, and no additional defects were found. Tests were not run because dependencies are unavailable.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli/src/command-internal/config-validate.parity.unit.test.ts:36 |
test-hygiene |
claude | The temporary config directory leaks when setup or an assertion fails because its cleanup is not registered with a scope or finalizer. This behavior predates the PR. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Flaky test check: ✅ no flaky testsCommit Each execution is a separate Vitest process; |
803f103 to
1465049
Compare
TL;DR
brings the last excluded test files under the effect lint
whats introduced?
--remoteand config values work and thelocal-db-runningintegration test drop theirnode:imports andprocess.envwrites forFileSystem,Path,Configandvi.stubEnvErrorinstead ofunknowngoldenJsonbecomes an effect, so its four callers yield itref