Skip to content

fix: upgraded packages to fix vulnerabilities #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Raj-StepSecurity merged 1 commit into from
Jul 10, 2026
Merged

fix: upgraded packages to fix vulnerabilities #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions base-action/bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 39 additions & 0 deletions base-action/test/mcp-test/osv-scanner.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
[[IgnoredVulns]]
id = "GHSA-345p-7cg4-v4c7"
reason = "test dependencies"
Comment on lines +1 to +3

@claude claude Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two concerns with this new suppression file:

Prefer upgrading over suppressing. This fixture's lockfile is stale — package.json requests @modelcontextprotocol/sdk@^1.24.0 but bun.lock still resolves 1.12.0 (its workspace spec even reads ^1.11.0). A bun install in this dir would pull the SDK to 1.24+ (newer express, qs, send, etc.) and likely eliminate most of these 10 advisories at the source rather than masking them. Suppressing a stale lockfile leaves the fixture pinned to known-vulnerable transitive deps.

Blanket reasons aren't auditable. All 10 entries use the identical reason "test dependencies", unlike the repo-root osv-scanner.toml, which gives specific per-vuln rationale (e.g. "project does not use WebSocket connections"). Since osv-scanner's IgnoredVulns match by advisory ID with no package/path scoping, a future reader can't tell whether each suppression is still valid. At minimum, name the affected package per entry. Also worth confirming none of these 10 IDs overlap a still-vulnerable package in the shipped root/base-action trees (the root package also depends on @modelcontextprotocol/sdk), so an ID-based ignore can't leak into production coverage.


[[IgnoredVulns]]
id = "GHSA-8r9q-7v3j-jr4g"
reason = "test dependencies"

[[IgnoredVulns]]
id = "GHSA-w48q-cv73-mx4w"
reason = "test dependencies"

[[IgnoredVulns]]
id = "GHSA-2g4f-4pwh-qvx6"
reason = "test dependencies"

[[IgnoredVulns]]
id = "GHSA-wqch-xfxh-vrr4"
reason = "test dependencies"

[[IgnoredVulns]]
id = "GHSA-27v5-c462-wpq7"
reason = "test dependencies"

[[IgnoredVulns]]
id = "GHSA-j3q9-mxjg-w52f"
reason = "test dependencies"

[[IgnoredVulns]]
id = "GHSA-6rw7-vpxm-498p"
reason = "test dependencies"

[[IgnoredVulns]]
id = "GHSA-q8mj-m7cp-5q26"
reason = "test dependencies"

[[IgnoredVulns]]
id = "GHSA-w7fw-mjwx-w883"
reason = "test dependencies"
Loading
Loading