fix: upgraded packages to fix vulnerabilities - #41
Conversation
| [[IgnoredVulns]] | ||
| id = "GHSA-345p-7cg4-v4c7" | ||
| reason = "test dependencies" |
There was a problem hiding this comment.
Two concerns with this new suppression file:
Prefer upgrading over suppressing. This fixture's lockfile is stale — package.json requests @modelcontextprotocol/sdk@^1.24.0 but bun.lock still resolves 1.12.0 (its workspace spec even reads ^1.11.0). A bun install in this dir would pull the SDK to 1.24+ (newer express, qs, send, etc.) and likely eliminate most of these 10 advisories at the source rather than masking them. Suppressing a stale lockfile leaves the fixture pinned to known-vulnerable transitive deps.
Blanket reasons aren't auditable. All 10 entries use the identical reason "test dependencies", unlike the repo-root osv-scanner.toml, which gives specific per-vuln rationale (e.g. "project does not use WebSocket connections"). Since osv-scanner's IgnoredVulns match by advisory ID with no package/path scoping, a future reader can't tell whether each suppression is still valid. At minimum, name the affected package per entry. Also worth confirming none of these 10 IDs overlap a still-vulnerable package in the shipped root/base-action trees (the root package also depends on @modelcontextprotocol/sdk), so an ID-based ignore can't leak into production coverage.
Code review summaryReviewed across quality, security, performance, tests, and docs. This is a low-risk, well-targeted upgrade — no blocking issues. Notes below (one inline on the new ✅ The Worth a follow-up — the root Minor — the PR body is empty. A one-line description listing which advisories are fixed vs. suppressed, and why the two-major |
No description provided.