Skip to content

fix(android): scope logcat crash detection to app process only #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abueide merged 1 commit into from
May 2, 2026
Merged

fix(android): scope logcat crash detection to app process only #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions examples/android/tests/test-suite.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,16 +342,23 @@ processes:
exit 1
fi

# Always save logcat snapshot for analysis
# Save full logcat for offline analysis
adb -s "$serial" logcat -d > "$_logs_dir/logcat-final.txt" 2>&1 || true

# Scan for crash patterns in logcat (AndroidRuntime tag is the definitive crash signal)
# Scan for crash patterns scoped to our app process only
APP_PID=$(adb -s "$serial" shell pidof "${ANDROID_APP_ID}" 2>/dev/null || true)
if [ -n "$APP_PID" ]; then
adb -s "$serial" logcat -d --pid="$APP_PID" > "$_logs_dir/logcat-app.txt" 2>&1 || true
else
grep -F "${ANDROID_APP_ID}" "$_logs_dir/logcat-final.txt" > "$_logs_dir/logcat-app.txt" 2>/dev/null || true
fi

crash_patterns="FATAL EXCEPTION|AndroidRuntime.*FATAL"
if grep -qiE "$crash_patterns" "$_logs_dir/logcat-final.txt" 2>/dev/null; then
if grep -qiE "$crash_patterns" "$_logs_dir/logcat-app.txt" 2>/dev/null; then
echo ""
echo "FAIL: Crash patterns detected in logcat"
echo "FAIL: Crash patterns detected in app logcat"
echo "--- Error lines ---"
grep -iE "$crash_patterns" "$_logs_dir/logcat-final.txt" | tail -20
grep -iE "$crash_patterns" "$_logs_dir/logcat-app.txt" | tail -20
echo "---"
echo "Full logcat: $_logs_dir/logcat-final.txt"
printf 'fail\nCrash patterns detected in logcat\n' > "$_step_dir/$_step.status"
Expand Down
24 changes: 15 additions & 9 deletions examples/react-native/tests/test-suite-all-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,27 +473,33 @@ processes:

echo " Checking logs for errors..."

# Save logcat snapshot to file
# Save full logcat for offline analysis, then extract app-only logs
adb -s "$serial" logcat -d > "$_logs_dir/logcat-android-verify.txt" 2>&1 || true
APP_PID=$(adb -s "$serial" shell pidof "${ANDROID_APP_ID}" 2>/dev/null || true)
if [ -n "$APP_PID" ]; then
adb -s "$serial" logcat -d --pid="$APP_PID" > "$_logs_dir/logcat-android-app.txt" 2>&1 || true
else
grep -F "${ANDROID_APP_ID}" "$_logs_dir/logcat-android-verify.txt" > "$_logs_dir/logcat-android-app.txt" 2>/dev/null || true
fi

# Check for Metro connection errors
metro_patterns="unable.*load.*script|could.*not.*connect.*metro|connection.*refused.*8081|packaged.*correctly.*for.*release"
if grep -qiE "$metro_patterns" "$_logs_dir/logcat-android-verify.txt" 2>/dev/null; then
if grep -qiE "$metro_patterns" "$_logs_dir/logcat-android-app.txt" 2>/dev/null; then
echo "FAIL: App cannot connect to Metro bundler"
echo "--- Error lines ---"
grep -iE "unable|load|script|connect|metro|refused|8081|packaged|release|bundle" "$_logs_dir/logcat-android-verify.txt" | tail -30
grep -iE "unable|load|script|connect|metro|refused|8081|packaged|release|bundle" "$_logs_dir/logcat-android-app.txt" | tail -30
echo "---"
echo "Full logcat: $_logs_dir/logcat-android-verify.txt"
printf 'fail\nAndroid app cannot connect to Metro bundler\n' > "$_step_dir/$_step.status"
exit 1
fi

# Check for native crash patterns
# Check for native crash patterns (scoped to our app)
crash_patterns="FATAL EXCEPTION|AndroidRuntime.*FATAL"
if grep -qiE "$crash_patterns" "$_logs_dir/logcat-android-verify.txt" 2>/dev/null; then
echo "FAIL: Crash patterns detected in logcat"
if grep -qiE "$crash_patterns" "$_logs_dir/logcat-android-app.txt" 2>/dev/null; then
echo "FAIL: Crash patterns detected in app logcat"
echo "--- Error lines ---"
grep -iE "$crash_patterns" "$_logs_dir/logcat-android-verify.txt" | tail -20
grep -iE "$crash_patterns" "$_logs_dir/logcat-android-app.txt" | tail -20
echo "---"
echo "Full logcat: $_logs_dir/logcat-android-verify.txt"
printf 'fail\nCrash patterns detected in Android logcat\n' > "$_step_dir/$_step.status"
Expand All @@ -502,10 +508,10 @@ processes:

# Check for React Native JS errors
rn_patterns="ReactNativeJS.*Error|Unhandled JS Exception|RedBoxError"
if grep -qiE "$rn_patterns" "$_logs_dir/logcat-android-verify.txt" 2>/dev/null; then
if grep -qiE "$rn_patterns" "$_logs_dir/logcat-android-app.txt" 2>/dev/null; then
echo "FAIL: React Native JS error detected"
echo "--- Error lines ---"
grep -iE "$rn_patterns" "$_logs_dir/logcat-android-verify.txt" | tail -20
grep -iE "$rn_patterns" "$_logs_dir/logcat-android-app.txt" | tail -20
echo "---"
echo "Full logcat: $_logs_dir/logcat-android-verify.txt"
printf 'fail\nReact Native JS error detected on Android\n' > "$_step_dir/$_step.status"
Expand Down
24 changes: 15 additions & 9 deletions examples/react-native/tests/test-suite-android-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,27 +404,33 @@ processes:

echo " Checking logs for errors..."

# Save logcat snapshot to file
# Save full logcat for offline analysis, then extract app-only logs
adb -s "$serial" logcat -d > "$_logs_dir/logcat-verify.txt" 2>&1 || true
APP_PID=$(adb -s "$serial" shell pidof "${ANDROID_APP_ID}" 2>/dev/null || true)
if [ -n "$APP_PID" ]; then
adb -s "$serial" logcat -d --pid="$APP_PID" > "$_logs_dir/logcat-app.txt" 2>&1 || true
else
grep -F "${ANDROID_APP_ID}" "$_logs_dir/logcat-verify.txt" > "$_logs_dir/logcat-app.txt" 2>/dev/null || true
fi

# Check for Metro connection errors (these appear in red box)
metro_patterns="unable.*load.*script|could.*not.*connect.*metro|connection.*refused.*8081|packaged.*correctly.*for.*release"
if grep -qiE "$metro_patterns" "$_logs_dir/logcat-verify.txt" 2>/dev/null; then
if grep -qiE "$metro_patterns" "$_logs_dir/logcat-app.txt" 2>/dev/null; then
echo "FAIL: App cannot connect to Metro bundler"
echo "--- Error lines ---"
grep -iE "unable|load|script|connect|metro|refused|8081|packaged|release|bundle" "$_logs_dir/logcat-verify.txt" | tail -30
grep -iE "unable|load|script|connect|metro|refused|8081|packaged|release|bundle" "$_logs_dir/logcat-app.txt" | tail -30
echo "---"
echo "Full logcat: $_logs_dir/logcat-verify.txt"
printf 'fail\nApp cannot connect to Metro bundler\n' > "$_step_dir/$_step.status"
exit 1
fi

# Check for native crash patterns
# Check for native crash patterns (scoped to our app)
crash_patterns="FATAL EXCEPTION|AndroidRuntime.*FATAL"
if grep -qiE "$crash_patterns" "$_logs_dir/logcat-verify.txt" 2>/dev/null; then
echo "FAIL: Crash patterns detected in logcat"
if grep -qiE "$crash_patterns" "$_logs_dir/logcat-app.txt" 2>/dev/null; then
echo "FAIL: Crash patterns detected in app logcat"
echo "--- Error lines ---"
grep -iE "$crash_patterns" "$_logs_dir/logcat-verify.txt" | tail -20
grep -iE "$crash_patterns" "$_logs_dir/logcat-app.txt" | tail -20
echo "---"
echo "Full logcat: $_logs_dir/logcat-verify.txt"
printf 'fail\nCrash patterns detected in logcat\n' > "$_step_dir/$_step.status"
Expand All @@ -433,10 +439,10 @@ processes:

# Check for React Native JS errors
rn_patterns="ReactNativeJS.*Error|Unhandled JS Exception|RedBoxError"
if grep -qiE "$rn_patterns" "$_logs_dir/logcat-verify.txt" 2>/dev/null; then
if grep -qiE "$rn_patterns" "$_logs_dir/logcat-app.txt" 2>/dev/null; then
echo "FAIL: React Native JS error detected"
echo "--- Error lines ---"
grep -iE "$rn_patterns" "$_logs_dir/logcat-verify.txt" | tail -20
grep -iE "$rn_patterns" "$_logs_dir/logcat-app.txt" | tail -20
echo "---"
echo "Full logcat: $_logs_dir/logcat-verify.txt"
printf 'fail\nReact Native JS error detected\n' > "$_step_dir/$_step.status"
Expand Down
Loading