fix(android): scope logcat crash detection to app process only#62
Merged
fix(android): scope logcat crash detection to app process only#62
Conversation
The verify-app-running steps were dumping full device logcat then scanning for FATAL EXCEPTION patterns across all processes. This could cause false failures if a system app crashed on the emulator. Now extracts app-specific logs via adb logcat --pid before scanning. Fixes: test-suite.yaml, test-suite-android-e2e.yaml, test-suite-all-e2e.yaml Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same fix as #59 (iOS), but for Android. Scopes logcat crash pattern scanning to the app's PID so system app crashes don't cause false E2E failures.
Changes
adb logcat --pidusingANDROID_APP_IDbefore scanning for crash patternsgrep -Fpackage name filtering if PID lookup fails (app already exited)test-suite.yaml,test-suite-android-e2e.yaml,test-suite-all-e2e.yamlWhy
The verify-app-running steps were scanning full device logcat for
FATAL EXCEPTION|AndroidRuntime.*FATAL. Any system app crash on the emulator would trigger a false failure — the same class of bug that hit the iOS suites in #59 with Apple News.🤖 Generated with Claude Code