fix(rn): scope simulator log capture to app process only#59
Merged
Conversation
The verify-app-running step was capturing all simulator logs then scanning for crash patterns. This caused false failures when other system apps (e.g. Apple News) crashed on the simulator. Filter log capture with --predicate "process == ..." using IOS_APP_SCHEME. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes false E2E failures caused by crash patterns from unrelated system apps (e.g. Apple News) on the iOS simulator.
Changes
--predicate "process == \"$APP_PROCESS\""tolog showcommands intest-suite-ios-e2e.yamlandtest-suite-all-e2e.yamlIOS_APP_SCHEME(set in devbox.json) to scope to the RN app processWhy
PR #56 CI failed because
NewsToday2(Apple News) threw assertion failures on the simulator. The verify step's unscoped log scan matchedAssertion failurefrom that process and reported it as our app crashing. The native iOS and repro test suites already had this filtering (process == "ios"); only the RN suites were missing it.🤖 Generated with Claude Code