feat(android): route plugin.json scripts through segkit#58
Merged
Conversation
Replace direct android.sh calls in the Android plugin's convenience scripts with segkit android delegation. No fallbacks — segkit must be available on PATH or the command fails immediately. Scripts updated: android:sync, android:devices:eval, start:android, start:emu, stop:emu, reset:emu. Also adds `segkit:install` devbox script for cargo install --path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates Android plugin convenience scripts to call
segkit androidinstead ofandroid.shdirectly. No fallbacks — if segkit isn't on PATH, the command fails immediately.Changes
android.shwithsegkit androidin 6 plugin.json scripts:android:sync,android:devices:eval,start:android,start:emu,stop:emu,reset:emusegkit:installdevbox script (cargo install --path segkit) for easy local installationWhy
Phase 1.2 of the shell-to-Rust migration. Routes user-facing plugin commands through segkit's delegation layer, which logs timing and errors to JSONL for observability. Failing fast on missing segkit ensures issues surface immediately during the conversion.
Note: CI E2E tests are unaffected — they use process-compose which calls
android.shdirectly. Onlydevbox run start:emuand similar user convenience commands are routed through segkit.🤖 Generated with Claude Code