feat(ios): route plugin.json scripts through segkit#60
Merged
Conversation
Replace direct ios.sh calls and inline script sourcing in the iOS plugin's convenience scripts with segkit ios delegation. No fallbacks. Scripts updated: ios:devices:eval, start:ios, start:sim, stop:sim. start:sim and stop:sim are simplified from multi-source bash one-liners to clean segkit ios simulator start/stop calls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates iOS plugin convenience scripts to call
segkit iosinstead ofios.shdirectly. No fallbacks — if segkit isn't on PATH, the command fails immediately.Changes
ios.shwithsegkit iosin 4 plugin.json scripts:ios:devices:eval,start:ios,start:sim,stop:simstart:sim/stop:simsimplified from inline multi-source bash one-liners to cleansegkit ios simulator start/stopcallsWhy
Phase 1.3 of the shell-to-Rust migration. Same pattern as PR #58 (Android). Routes user-facing plugin commands through segkit's delegation layer for timing/error observability.
CI E2E tests are unaffected — they use process-compose which calls
ios.shdirectly.🤖 Generated with Claude Code