Skip to content

Rename extern "unadjusted" to extern "llvm-intrinsic" - #161398

Merged
rust-bors[bot] merged 6 commits into
rust-lang:mainfrom
bjorn3:rename_unadjusted_abi
Aug 28, 2026
Merged

Rename extern "unadjusted" to extern "llvm-intrinsic"#161398
rust-bors[bot] merged 6 commits into
rust-lang:mainfrom
bjorn3:rename_unadjusted_abi

Conversation

@bjorn3

@bjorn3 bjorn3 commented Aug 20, 2026

Copy link
Copy Markdown
Member

This makes it clear that it is only meant for LLVM intrinsics and not for defining or calling arbitrary user functions.

Follow up to #160077

@rustbot

rustbot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

compiler-builtins is developed in its own repository. If possible, consider making this change to rust-lang/compiler-builtins instead.

cc @tgross35

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

@rustbot rustbot added A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2026
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 20, 2026
@rustbot

rustbot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from JohnTitor, Mark-Simulacrum, clarfonthey, nia-e, tgross35

Comment thread compiler/rustc_feature/src/removed.rs Outdated

@RalfJung RalfJung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it. :)
I only carefully looked at the Miri parts, those LGTM.

View changes since this review

@rust-log-analyzer

This comment has been minimized.

@bjorn3
bjorn3 force-pushed the rename_unadjusted_abi branch from 515519e to 130b07c Compare August 20, 2026 14:17
Comment thread compiler/rustc_abi/src/extern_abi.rs Outdated
@rust-log-analyzer

This comment has been minimized.

@bjorn3
bjorn3 force-pushed the rename_unadjusted_abi branch from 130b07c to e21f4cf Compare August 20, 2026 15:04
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bjorn3
bjorn3 force-pushed the rename_unadjusted_abi branch from 5b23cd8 to c0dd7fd Compare August 21, 2026 13:38
@rust-log-analyzer

This comment has been minimized.

@rust-bors

This comment has been minimized.

@bjorn3
bjorn3 force-pushed the rename_unadjusted_abi branch from c0dd7fd to 001d6e4 Compare August 27, 2026 10:23
@bjorn3
bjorn3 force-pushed the rename_unadjusted_abi branch from 001d6e4 to 3f09e9e Compare August 27, 2026 10:26
@bjorn3

bjorn3 commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

CI passed. @tgross35 would you be able to take a look soon. This PR is fairly large, so it may be a bit bitrot prone.

@tgross35 tgross35 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the standpoint of this just being a renaming, but we should make sure the regular stdarch maintainers are aware.

@folkertdev @adamgemmell @sayantn is stdarch reasonably up to date with r-l/r so this isn't going to cause conflicts with the next sync?

(r=me after one of them confirm)

@bors rollup=iffy p=5

View changes since this review

@folkertdev

Copy link
Copy Markdown
Contributor

Yes, this shouldn't cause any (large) issues

@bors r=tgross35

@rust-bors

rust-bors Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 3f09e9e has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2026
@tgross35

Copy link
Copy Markdown
Member

Bors preserves iffy/never but doesn't preserve priority?

@bors p=5

@rust-bors

This comment has been minimized.

@Zalathar

Copy link
Copy Markdown
Member

Bors preserves iffy/never but doesn't preserve priority?

I think it interpreted the “p=5” as a note explaining ”rollup=iffy”, instead of as a separate directive.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 28, 2026
@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: tgross35
Duration: 3h 17m 43s
Pushing d0f2ef5 to main...

@rust-bors
rust-bors Bot merged commit d0f2ef5 into rust-lang:main Aug 28, 2026
14 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Aug 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e457a7b (parent) -> d0f2ef5 (this PR)

Test differences

Show 8 test diffs

Stage 1

  • [ui] tests/ui/feature-gates/feature-gate-abi_llvm-intrinsic.rs: [missing] -> pass (J0)
  • [ui] tests/ui/feature-gates/feature-gate-abi_unadjusted.rs: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/feature-gates/feature-gate-abi_llvm-intrinsic.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/feature-gates/feature-gate-abi_unadjusted.rs: pass -> [missing] (J1)

Stage 2

  • [ui] tests/ui/feature-gates/feature-gate-abi_llvm-intrinsic.rs: [missing] -> pass (J2)
  • [ui] tests/ui/feature-gates/feature-gate-abi_unadjusted.rs: pass -> [missing] (J2)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d0f2ef5e53039bd86fdcaa6e71860c4948880e04 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-stdlib-semver-check: 10m 29s -> 18m 5s (+72.5%)
  2. x86_64-gnu-gcc: 48m 57s -> 1h 21m (+66.6%)
  3. x86_64-gnu-gcc-core-tests: 10m 45s -> 17m 41s (+64.5%)
  4. x86_64-msvc-1: 1h 42m -> 2h 44m (+59.9%)
  5. i686-msvc-1: 1h 53m -> 2h 57m (+55.7%)
  6. test-various: 1h 36m -> 2h 17m (+43.1%)
  7. dist-x86_64-msvc-alt: 2h 6m -> 2h 56m (+39.8%)
  8. i686-gnu-nopt-2: 2h 23m -> 1h 27m (-38.6%)
  9. x86_64-gnu-llvm-22-2: 1h 16m -> 1h 45m (+37.6%)
  10. dist-x86_64-llvm-mingw: 1h 34m -> 2h 7m (+35.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (d0f2ef5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.6%, secondary -4.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.6% [2.6%, 2.7%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.0% [-6.5%, -1.5%] 2
All ❌✅ (primary) 2.6% [2.6%, 2.7%] 2

Cycles

Results (primary -0.6%, secondary -3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.1% [-2.2%, -2.0%] 2
Improvements ✅
(secondary)
-3.6% [-3.6%, -3.6%] 1
All ❌✅ (primary) -0.6% [-2.2%, 2.6%] 3

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 476.343s -> 475.629s (-0.15%)
Artifact size: 402.74 MiB -> 402.76 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) merged-by-bors This PR was explicitly merged by bors. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants