Tie extern "llvm-intrinsics" and llvm.* symbol names together - #161922
Tie extern "llvm-intrinsics" and llvm.* symbol names together#161922bjorn3 wants to merge 1 commit into
Conversation
LLVM intrinsics must always use extern "llvm-intrinsic" and extern "llvm-intrinsic" must only be used for actual LLVM intrinsics.
|
rustbot has assigned @ShoyuVanilla. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Not sure if this is the best place to do this check. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Sorry, I'm pretty ignorant about this area 😅 r? compiler |
| args.no_bound_vars().unwrap(), | ||
| DUMMY_SP, | ||
| ); | ||
| if let InstanceKind::LlvmIntrinsic(..) = instance.def { |
There was a problem hiding this comment.
I suppose that let ... else would be able to shave off some indentation below and make your expectation clear. This is up to you.
|
I reckon that the patch is incomplete. Are you going to "sanitize" the |
|
Both |
LLVM intrinsics must always use extern "llvm-intrinsic" and extern "llvm-intrinsic" must only be used for actual LLVM intrinsics.
Follow up to #161398