[6.40] [ntuple] Change signature of RRealField::SetQuantized and deprecate old one#22107
Merged
silverweed merged 1 commit intoroot-project:v6-40-00-patchesfrom Apr 30, 2026
Conversation
Instead of
SetQuantized(T min, T max, size_t nBits)
use
SetQuantized(size_t nBits, pair<T, T> valueRange)
Rationale:
- keep nBits in first position to be more consistent with SetTruncated
- prevent mistakes of argument wrong ordering where nBits is passed
first instead of min.
(cherry picked from commit 900fbdf)
jblomer
approved these changes
Apr 30, 2026
Test Results 22 files 22 suites 3d 11h 22m 59s ⏱️ Results for commit 027d6f6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22084, requested by @silverweed.