[ntuple] Change signature of RRealField::SetQuantized and deprecate old one#22084
Conversation
Instead of
SetQuantized(T min, T max, size_t nBits)
use
SetQuantized(size_t nBits, pair<T, T> valueRange)
Rationale:
- keep nBits in first position to be more consistent with SetTruncated
- prevent mistakes of argument wrong ordering where nBits is passed
first instead of min.
Test Results 22 files 22 suites 3d 12h 14m 36s ⏱️ Results for commit fd935a3. |
jblomer
left a comment
There was a problem hiding this comment.
Needs backporting to 6.40 if to be deprecated in 6.42.
|
If we deprecate in 6.40 and remove "already" in 6.42 (which needs synchronization with #22023), users will have little time to migrate. Maybe that's fine because 6.40 will be an LTS and probably few users call |
|
@hahnjo I'm pretty sure the quantized floats are advanced enough to be currently almost unused and the change is purely mechanical, so I think we can afford it. But I'm also fine deprecating it in 6.40 and removing it in 6.44. |
|
/backport to 6.40 |
|
Preparing to backport PR #22084 to branch 6.40 requested by silverweed |
|
This PR has been backported to branch 6.40: #22107 |
Instead of
use
Rationale: