store: stamp in-flight until at TipOnly start; drop on Class C - #273
Merged
Conversation
Stamp until needs the in-progress wave height, not the last completed one. hold_partial still leaves started_hi untouched. Co-authored-by: Cursor <cursoragent@cursor.com>
Write keep-until and drain+fence/class_a_hi gates dropped layers too early. Layer until is lookup_started_hi at create; prune waits until confirmed tip covers that height. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner docs still described write freeze and class_a_hi drop. Match the stamp-at-note / Class C tip prune. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Retriggering CI: pull_request checks did not enqueue after open. |
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lookup_started_hiadvances when a lookup wave starts TipOnly (selected hi, beforeget_fk_by_txid_batch).hold_partialdoes not bump it.note_lookup_ok/note_archived_createsstamp layeruntil = lookup_started_hi(packmax_heightif that atomic is stillNone).class_a_hiare not drop gates. Disconnect stilldrop_from_heighton pack height.Live test (operator IBD)
Pause before stacking PR2 until a mainnet IBD shows:
iflight=stays until confirmed tip covers the lookup wave that was started when that pack was noted — not drop at Class A of the pack.leftover_nunchanged vs baseline (LiveUnion still present).parent create_fk unresolved.Do not open a mainnet datadir in the agent VM.
Test plan
cargo test -p rbitcoin-consensus --lib bq_resolvecargo test -p rbitcoin-query --lib in_flightcargo test -p rbitcoin-consensus --lib write_idempotentcargo test -p rbitcoin-net --lib confirmfmt,deny,clippy,ast-grep,test,windows,macos,multinode,coverage)Made with Cursor