store: drop in-flight when drain+fence exceeds until - #274
Merged
Conversation
Class C / fence tip can lead unpublished tx.head. In-flight prune needs the height both drain and the fence have actually passed. Co-authored-by: Cursor <cursoragent@cursor.com>
Class C tip as the prune gate released CreatePin layers while tx.head HWM still lagged (mainnet 258870 leftover miss_on=body). Keep until stamped at note_layer; drop only when drain_and_fence_hi > until. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
miss_on=bodywith identity at fk pastdrain_fkwhile Class C/fence had already run ahead.HeightFence::drain_and_fence_hi= min of drain height and fence tip).untilis still stamped atnote_layer(lookup_started_hi). Equality keeps. Class C tip is not a drop gate.Test plan
drain_and_fence_hi_is_min_of_drain_height_and_fence_tip(fence tip 40, drain on height 2 → 2)prune_keeps_until_drain_fence_exceeds_stamped_until/ confirm twin (keep at == until; drop at +1; drain lag keeps)inflight_binds_after_drain_before_fence/inflight_binds_after_fence_before_drainconfirm_engine_pins_spend_of_just_written_packfmtdenyclippyast-greptestwindowsmacosmultinodecoverage)Made with Cursor