Skip to content

store: drop in-flight when drain+fence exceeds until - #274

Merged
reardencode merged 2 commits into
masterfrom
store/inflight-until-drain-fence
Aug 26, 2026
Merged

store: drop in-flight when drain+fence exceeds until#274
reardencode merged 2 commits into
masterfrom
store/inflight-until-drain-fence

Conversation

@rearden-grok

@rearden-grok rearden-grok Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Mainnet IBD at 26% (height 258870) blacklisted a valid block: leftover miss_on=body with identity at fk past drain_fk while Class C/fence had already run ahead.
  • PR store: stamp in-flight until at TipOnly start; drop on Class C #273 pruned in-flight CreatePin layers when Class C tip ≥ until. This restores the drop gate to drain+fence height > until (HeightFence::drain_and_fence_hi = min of drain height and fence tip).
  • until is still stamped at note_layer (lookup_started_hi). Equality keeps. Class C tip is not a drop gate.

Test plan

  • drain_and_fence_hi_is_min_of_drain_height_and_fence_tip (fence tip 40, drain on height 2 → 2)
  • prune_keeps_until_drain_fence_exceeds_stamped_until / confirm twin (keep at == until; drop at +1; drain lag keeps)
  • inflight_binds_after_drain_before_fence / inflight_binds_after_fence_before_drain
  • confirm_engine_pins_spend_of_just_written_pack
  • required CI green (fmt deny clippy ast-grep test windows macos multinode coverage)

Made with Cursor

rearden-grok Bot and others added 2 commits August 26, 2026 09:49
Class C / fence tip can lead unpublished tx.head. In-flight prune needs
the height both drain and the fence have actually passed.

Co-authored-by: Cursor <cursoragent@cursor.com>
Class C tip as the prune gate released CreatePin layers while tx.head
HWM still lagged (mainnet 258870 leftover miss_on=body). Keep until
stamped at note_layer; drop only when drain_and_fence_hi > until.

Co-authored-by: Cursor <cursoragent@cursor.com>
@reardencode
reardencode merged commit 657d8b7 into master Aug 26, 2026
13 checks passed
@rearden-grok
rearden-grok Bot deleted the store/inflight-until-drain-fence branch August 26, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant