Repository navigation
fix(types): Require TypeScript 4.0; remove broken TS 3.x declarations - #4151
Merged
Merged
Conversation
The ts3.4 typesVersions outputs of endpoint, normalizr, core, react, graphql, img and test did not type-check on any TypeScript 3.x, and rest already required 4.0. use-enhanced-reducer keeps its ts3.4 output, which still works on TS 3.4+. With no outputs below 4.0 left, LEGACY_MIN_TS is a no-op, so it is removed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0112vdfv1WoJN5LqwMkiksab
🦋 Changeset detectedLatest commit: ede4059 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0112vdfv1WoJN5LqwMkiksab
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0112vdfv1WoJN5LqwMkiksab
ntucker
marked this pull request as ready for review
October 4, 2026 15:26
Contributor
|
Size Change: 0 B Total Size: 103 kB ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4151 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 158 158
Lines 3079 3079
Branches 616 616
=======================================
Hits 3015 3015
Misses 18 18
Partials 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Nathaniel · project thread
Follow-up from #4122 / #4140.
Motivation
Before:
package.jsontypesVersionsadvertised">=3.4", but thets3.4/declarations didn't type-check on any TypeScript 3.x (withskipLibCheck: false):import type(TS 3.8+), and recursive type aliases need 3.7...args: readonly [...Parameters<E>]) in endpoint/normalizrSnapshotInterface, coreController, and every react hook, plusReact.JSXand default React imports@data-client/restnever had a 3.x entry, so react + rest never worked on 3.xAfter: TypeScript 4.0 is the minimum, matching rest and the oldest TS in the
esmodule-typesCI matrix.Solution
">=3.4"typesVersionsentry,ts3.4fromfiles, and thets3.4build from core, endpoint, normalizr, react, graphql, img and test; deleteendpoint/src-3.4-types.@data-client/use-enhanced-reducerkeeps itsts3.4output: it type-checks on TS 3.4 and 3.9, and it isn't version-linked.LEGACY_MIN_TSis now a no-op (no outputs below 4.0), so it's removed fromci:build:legacy-typesandbuild-legacy-types.sh.Verified:
ts4.*outputs for endpoint/normalizr/rest are byte-identical to master;yarn build:typespasses;typetest-libcheckpasses on TS 4.0.8.🤖 Generated with Claude Code
https://claude.ai/code/session_0112vdfv1WoJN5LqwMkiksab
Generated by Claude Code
Note
Medium Risk
Breaking for consumers on TypeScript 3.x; runtime behavior is unchanged but published typings and minimum compiler version shift across multiple packages.
Overview
BREAKING: Published
@data-client/*packages now require TypeScript 4.0+. The brokents3.4declaration trees andtypesVersions">=3.4"entries are removed from core, endpoint, normalizr, react, graphql, img, and test; endpoint’ssrc-3.4-typesoverlay is deleted.Legacy type publishing is trimmed to TS ≥ 4.0 only:
build:legacy-typesno longer emits 3.4,LEGACY_MIN_TSis dropped from CI andbuild-legacy-types.sh, and endpoint drops the oldschemas-3.7babel ignore.@data-client/use-enhanced-reducerstill shipsts3.4(unchanged).Docs and release notes state 4.0+; a minor changeset marks the break for the affected packages.
Reviewed by Cursor Bugbot for commit ede4059. Bugbot is set up for automated code reviews on this repo. Configure here.